Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] update to 3.21.0 #18952

Closed
xavier2k6 opened this issue Jul 14, 2021 · 6 comments · Fixed by #18955
Closed

[CMake] update to 3.21.0 #18952

xavier2k6 opened this issue Jul 14, 2021 · 6 comments · Fixed by #18955
Assignees
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Comments

@xavier2k6
Copy link
Contributor

xavier2k6 commented Jul 14, 2021

Library name: CMake from Kitware

New version number: 3.21.0

Other information that may be useful (release notes, etc...)

ref.:
scripts/vcpkgTools.xml
https://cmake.org/download/#:~:text=Latest%20Release
https://cmake.org/cmake/help/v3.21/release/3.21.html#cmake-3-21-release-notes

@NancyLi1013 NancyLi1013 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jul 15, 2021
@cenit
Copy link
Contributor

cenit commented Jul 15, 2021

microsoft/vcpkg-tool#107

a new vcpkg-tool is also mandatory for cmake 3.21
fixes already landed there, I hope it can be released soon to unblock pipelines that are already using cmake 3.21

@davidhunter22
Copy link

Can I second the request for a new vcpkg-tool release. Not having the commit microsoft/vcpkg-tool@8b1c04b means anyone using vcpkg migrating to CMake 3.21 will face doom and gloom. See https://gitlab.kitware.com/cmake/cmake/-/issues/22371 and https://gitlab.kitware.com/cmake/cmake/-/issues/22422 for at least two reports of the problem

@JackBoosY
Copy link
Contributor

@davidhunter22 We will release the next version in a few days.

@snnn
Copy link
Member

snnn commented Jul 17, 2021

It will affect a lot of github users. The latest Windows 2019 image provided by github actions works fine, because it uses cmake 3.20.5. (see https://github.com/actions/virtual-environments/blob/releases/win19/20210711/images/win/Windows2019-Readme.md).

But once they regenerate the image, vcpkg will crash. Usually they update the image weekly.

@9prady9
Copy link
Contributor

9prady9 commented Jul 29, 2021

It will affect a lot of github users. The latest Windows 2019 image provided by github actions works fine, because it uses cmake 3.20.5. (see https://github.com/actions/virtual-environments/blob/releases/win19/20210711/images/win/Windows2019-Readme.md).

But once they regenerate the image, vcpkg will crash. Usually they update the image weekly.

This kind of eventually happened and our CI job fails running vcpkg command because Windows image now has CMake 3.21

@JackBoosY Any hints on the ETA for next vcpkg release ?

@JackBoosY
Copy link
Contributor

@9prady9 The update for cmake 3.21.0 is ready for merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants