-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Update to 3.21.1 #18955
[cmake] Update to 3.21.1 #18955
Conversation
Waiting for vcpkg next release to fix the regressions. |
Depends on #18983 |
pistache should be fixed by #18994 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I already commented in #18983 (comment), but it may belong to this PR: Users are not notified that they need to re-bootstrap in order to enable cmake 3.21.0 support: Lines 28 to 29 in 111220b
|
…jack/update_cmake_3.21.0
…kBoosY/vcpkg into dev/jack/update_cmake_3.21.0
…jack/update_cmake_3.21.0
@BillyONeal
In our pipeline image, internal meson version is 0.53.2, but we required 0.58.1 in vcpkg: vcpkg/scripts/cmake/vcpkg_find_acquire_program.cmake Lines 254 to 270 in 7dbc055
|
there is already cmake 3.21.1, which provides some fixes for vs 2022 preview 2 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The cmake regressions are fake now, need to rerun the pipeline tests. |
Depends on #19361. |
That's merged now, any other hold-ups? |
Depends on #19453. |
Ping @dan-shaw for merge this PR. |
Thanks for your contribution! |
Fixes #18952.