Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[many ports] Claim to only support static although they could also be built on normal triplets #25179

Closed
6 tasks done
Thomas1664 opened this issue Jun 10, 2022 · 0 comments · Fixed by #26951
Closed
6 tasks done

[many ports] Claim to only support static although they could also be built on normal triplets #25179

Thomas1664 opened this issue Jun 10, 2022 · 0 comments · Fixed by #26951
Assignees
@Adela0814
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@Thomas1664
Copy link
Contributor

Thomas1664 commented Jun 10, 2022 •
edited by Adela0814
Loading

Many ports claim in their supports to only support static linking. This prevents them from being built on x64-uwp, x64-windows, x64-linux, x64-osx. However, most likely they do in fact support these triplets.

The correct way to prevent dynamic linkage is to add vcpkg_check_linkage(ONLY_STATIC_LIBRARY) at the top of the port file.

The following ports are affected:

  • apsi
  • concurrencpp (fail on Linux)
  • mfl (skip on UNIX)
  • mmloader (fail on every non-static triplet)
  • pffft
  • socket-io-client

Note that some of these ports may only work on Windows because other platforms were never tested. Maybe there are false positives on the list as well.
@Adela0814 Adela0814 self-assigned this Jun 13, 2022
@Adela0814 Adela0814 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 13, 2022
@Adela0814 Adela0814 mentioned this issue Jun 13, 2022
Merged
@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jun 14, 2022
@Thomas1664 Thomas1664 mentioned this issue Jun 14, 2022
Merged
This was referenced Jun 23, 2022
Merged
Merged
@Adela0814 Adela0814 mentioned this issue Jul 20, 2022
Merged
@Thomas1664 Thomas1664 mentioned this issue Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adela0814 Adela0814

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mfl] Fix supports for building on normal triplets Thomas1664/vcpkg
2 participants
@Thomas1664 @Adela0814