Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mfl] Fix supports for building on normal triplets #26951

Merged
merged 6 commits into from
Oct 9, 2022
Merged

[mfl] Fix supports for building on normal triplets #26951

merged 6 commits into from
Oct 9, 2022

Conversation

Thomas1664
Copy link
Contributor

Describe the pull request

github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2022
View reviewed changes
@Thomas1664
Copy link
Contributor Author

mfl triggers an ICE:

cl : Command line warning D9025 : overriding '/W3' with '/W4'
D:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\noad\big_op.cpp(96) : fatal error C1001: Internal compiler error.
(compiler file 'D:\a\_work\1\s\src\vctools\Compiler\Utc\src\p2\main.c', line 224)
 To work around this problem, try simplifying or changing the program near the locations listed above.
If possible please provide a repro here: https://developercommunity.visualstudio.com 
Please choose the Technical Support command on the Visual C++ 
 Help menu, or open the Technical Support help file for more information
  cl!RaiseException()+0x6c
  cl!RaiseException()+0x6c
  cl!DllGetObjHandler()+0xdb94f
  cl!DllGetObjHandler()+0x11fb05

[58/84] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x64\cl.exe   /TP -DFMT_SHARED -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\. -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\.\..\..\include -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\.\..\..\src -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\include -external:ID:\installed\x64-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /W4 /w14242 /w14254 /w14263 /w14265 /w14287 /we4289 /w14296 /w14311 /w14545 /w14546 /w14547 /w14549 /w14555 /w14619 /w14640 /w14826 /w14905 /w14906 /w14928 /WX /permissive- -std:c++20 /showIncludes /Fotests\unit_tests\CMakeFiles\unit_tests.dir\node\box.cpp.obj /Fdtests\unit_tests\CMakeFiles\unit_tests.dir\ /FS -c D:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\node\box.cpp
cl : Command line warning D9025 : overriding '/W3' with '/W4'
[59/84] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x64\cl.exe   /TP -DFMT_SHARED -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\. -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\.\..\..\include -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\.\..\..\src -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\include -external:ID:\installed\x64-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /W4 /w14242 /w14254 /w14263 /w14265 /w14287 /we4289 /w14296 /w14311 /w14545 /w14546 /w14547 /w14549 /w14555 /w14619 /w14640 /w14826 /w14905 /w14906 /w14928 /WX /permissive- -std:c++20 /showIncludes /Fotests\unit_tests\CMakeFiles\unit_tests.dir\node\node.cpp.obj /Fdtests\unit_tests\CMakeFiles\unit_tests.dir\ /FS -c D:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\node\node.cpp
cl : Command line warning D9025 : overriding '/W3' with '/W4'
[60/84] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x64\cl.exe   /TP -DFMT_SHARED -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\. -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\.\..\..\include -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\.\..\..\src -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\include -external:ID:\installed\x64-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /W4 /w14242 /w14254 /w14263 /w14265 /w14287 /we4289 /w14296 /w14311 /w14545 /w14546 /w14547 /w14549 /w14555 /w14619 /w14640 /w14826 /w14905 /w14906 /w14928 /WX /permissive- -std:c++20 /showIncludes /Fotests\unit_tests\CMakeFiles\unit_tests.dir\noad\script.cpp.obj /Fdtests\unit_tests\CMakeFiles\unit_tests.dir\ /FS -c D:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\noad\script.cpp
FAILED: tests/unit_tests/CMakeFiles/unit_tests.dir/noad/script.cpp.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x64\cl.exe   /TP -DFMT_SHARED -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\. -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\.\..\..\include -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\.\..\..\src -ID:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\include -external:ID:\installed\x64-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /W4 /w14242 /w14254 /w14263 /w14265 /w14287 /we4289 /w14296 /w14311 /w14545 /w14546 /w14547 /w14549 /w14555 /w14619 /w14640 /w14826 /w14905 /w14906 /w14928 /WX /permissive- -std:c++20 /showIncludes /Fotests\unit_tests\CMakeFiles\unit_tests.dir\noad\script.cpp.obj /Fdtests\unit_tests\CMakeFiles\unit_tests.dir\ /FS -c D:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\noad\script.cpp
cl : Command line warning D9025 : overriding '/W3' with '/W4'
D:\buildtrees\mfl\src\v0.0.1-fdd809ab97.clean\tests\unit_tests\noad\script.cpp(95) : fatal error C1001: Internal compiler error.
(compiler file 'D:\a\_work\1\s\src\vctools\Compiler\Utc\src\p2\main.c', line 224)
 To work around this problem, try simplifying or changing the program near the locations listed above.
If possible please provide a repro here: https://developercommunity.visualstudio.com 
Please choose the Technical Support command on the Visual C++ 
 Help menu, or open the Technical Support help file for more information
  cl!RaiseException()+0x6c
  cl!RaiseException()+0x6c
  cl!DllGetObjHandler()+0xdb94f
  cl!DllGetObjHandler()+0x11fb05

Since the ICE occurs inside the tests directory I patch out the tests.

github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2022
View reviewed changes
@Thomas1664
Copy link
Contributor Author 

[55/269] cmd.exe /C "cd /D D:\buildtrees\fbthrift\x64-windows-dbg\thrift\compiler\generate && D:\buildtrees\fbthrift\x64-windows-dbg\bin\compiler_generate_build_templates.exe D:/buildtrees/fbthrift/src/2.03.21.00-009f4e66c2.clean/thrift/compiler/generate/templates > templates.cc"
FAILED: thrift/compiler/generate/templates.cc D:/buildtrees/fbthrift/x64-windows-dbg/thrift/compiler/generate/templates.cc 
cmd.exe /C "cd /D D:\buildtrees\fbthrift\x64-windows-dbg\thrift\compiler\generate && D:\buildtrees\fbthrift\x64-windows-dbg\bin\compiler_generate_build_templates.exe D:/buildtrees/fbthrift/src/2.03.21.00-009f4e66c2.clean/thrift/compiler/generate/templates > templates.cc"
[56/269] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x64\cl.exe   /TP -DBOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE -DFMT_SHARED -DGFLAGS_IS_A_DLL=1 -DGLOG_CUSTOM_PREFIX_SUPPORT -DGLOG_NO_ABBREVIATED_SEVERITIES -DNOMINMAX -DTHRIFT_HAVE_LIBSNAPPY=0 -DWIN32_LEAN_AND_MEAN -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_SCL_SECURE_NO_WARNINGS -D_STL_EXTRA_DISABLED_WARNINGS="4774 4987" -ID:\buildtrees\fbthrift\src\2.03.21.00-009f4e66c2.clean -ID:\buildtrees\fbthrift\x64-windows-dbg -external:ID:\installed\x64-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /EHs /GF /Zc:referenceBinding /Zc:rvalueCast /Zc:implicitNoexcept /Zc:strictStrings /Zc:threadSafeInit /Zc:throwingNew /permissive- /std:c++17 /wd4191 /wd4291 /wd4309 /wd4310 /wd4366 /wd4587 /wd4592 /wd4628 /wd4723 /wd4724 /wd4868 /wd4996 /wd4068 /wd4091 /wd4146 /wd4800 /wd4018 /wd4365 /wd4388 /wd4389 /wd4100 /wd4459 /wd4505 /wd4701 /wd4702 /wd4061 /wd4127 /wd4200 /wd4201 /wd4296 /wd4316 /wd4324 /wd4355 /wd4371 /wd4435 /wd4514 /wd4548 /wd4571 /wd4574 /wd4582 /wd4583 /wd4619 /wd4623 /wd4625 /wd4626 /wd4643 /wd4647 /wd4668 /wd4706 /wd4710 /wd4711 /wd4714 /wd4820 /wd5026 /wd5027 /wd5031 /wd5045 /we4099 /we4129 /we4566 /Zc:__cplusplus -std:c++17 /showIncludes /Fothrift\lib\cpp\CMakeFiles\concurrency.dir\concurrency\ThreadManager.cpp.obj /Fdthrift\lib\cpp\CMakeFiles\concurrency.dir\concurrency.pdb /FS -c D:\buildtrees\fbthrift\src\2.03.21.00-009f4e66c2.clean\thrift\lib\cpp\concurrency\ThreadManager.cpp

I don't understand what the problem is.

@LilyWangLL LilyWangLL self-assigned this Sep 26, 2022
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Sep 26, 2022
@Thomas1664 Thomas1664 changed the title [fbthrift,mfl] Fix supports for building on normal triplets [mfl] Fix supports for building on normal triplets Sep 30, 2022
@Thomas1664 Thomas1664 marked this pull request as ready for review September 30, 2022 10:30
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 8, 2022
@vicroms vicroms merged commit 3d8c3f5 into microsoft:master Oct 9, 2022
@Thomas1664 Thomas1664 deleted the only-static branch October 9, 2022 08:40
@Cheney-W Cheney-W mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[many ports] Claim to only support static although they could also be built on normal triplets
3 participants
@Thomas1664 @LilyWangLL @vicroms