Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[socket-io-client] fix supports #25206

Merged
merged 1 commit into from
Jun 15, 2022
Merged

[socket-io-client] fix supports #25206

merged 1 commit into from
Jun 15, 2022

Conversation

Adela0814
Copy link
Contributor

For #25179

@Adela0814 Adela0814 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Jun 13, 2022
@Adela0814 Adela0814 marked this pull request as ready for review June 13, 2022 07:56
@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jun 14, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 14, 2022
@vicroms vicroms merged commit d25fb81 into microsoft:master Jun 15, 2022
@Adela0814 Adela0814 deleted the Dev/Mengna/socket branch January 16, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Adela0814 @JonLiu1993 @vicroms @Mengna-Li