Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python site-packages scattered over installed tree #36345

Open
dg0yt opened this issue Jan 24, 2024 · 11 comments
Open

Python site-packages scattered over installed tree #36345

dg0yt opened this issue Jan 24, 2024 · 11 comments
Assignees
Labels
category:question This issue is a question Stale

Comments

@dg0yt
Copy link
Contributor

dg0yt commented Jan 24, 2024

There is no standard where to place python packages:

# /lib/python3.11/site-packages/
botan:x64-windows:/lib/python3.11/site-packages/
openimageio:x64-windows:/lib/python3.11/site-packages/

# /bin/Lib/site-packages/
paraview:x64-windows:/bin/Lib/site-packages/
vtk-dicom:x64-windows:/bin/Lib/site-packages/
vtk:x64-windows:/bin/Lib/site-packages/

# /tools/python3/site-packages/
xcb-proto:x64-windows:/tools/python3/site-packages/

# /tools/python3/Lib/site-packages/
python3:x64-windows:/tools/python3/Lib/site-packages/

# Python 2, I don't care.
python2:x64-windows:/share/python2/Lib/site-packages/
vcpkg-tool-python2:x64-windows:/manual-tools/vcpkg-tool-python2/Lib/site-packages/

# mozbuild2, I don't care.
vcpkg-tool-mozbuild:x64-windows:/tools/mozbuild/msys2/usr/lib/python3.10/site-packages/
vcpkg-tool-mozbuild:x64-windows:/tools/mozbuild/python3/Lib/site-packages/

Where to put them?

@Neumann-A
Copy link
Contributor

Where to put them?

Into ${PYTHON3_SITE} (requires dep on python3)

@dg0yt
Copy link
Contributor Author

dg0yt commented Jan 24, 2024

Into ${PYTHON3_SITE}

which is tools/python3/Lib for windows
and is lib/python3.11/site-packages otherwise.

@dg0yt
Copy link
Contributor Author

dg0yt commented Jan 24, 2024

... and the dep on python3 doesn't make vcpkg_get_python_packages use that version, even in a native build ...

@Neumann-A
Copy link
Contributor

... and the dep on python3 doesn't make vcpkg_get_python_packages use that version, even in a native build ...

I wouldn't advise mixing vcpkg_find_acquire_program(PYTHON3) and the version build by vcpkg. You can set it up to use it by providing the executable path explicitly but that seems to me more than sketchy.

@Cheney-W Cheney-W added the category:question This issue is a question label Jan 25, 2024
@dg0yt
Copy link
Contributor Author

dg0yt commented Jan 25, 2024

... and the dep on python3 doesn't make vcpkg_get_python_packages use that version, even in a native build ...

I wouldn't advise mixing vcpkg_find_acquire_program(PYTHON3) and the version build by vcpkg. You can set it up to use it by providing the executable path explicitly but that seems to me more than sketchy.

I don't want to mix. I want a clear recipe how to reliably provision ports with python and setuptools to have properply installed packages.
(Current work: #36342, #36354)

@Neumann-A
Copy link
Contributor

I don't want to mix. I want a clear recipe how to reliably provision ports with python and setuptools to have properply installed packages.

Not currently possible to do correctly. It requires to actually build and install python wheels from source (unless noneabi which is equivalent to header/script only ports.) To do it correctly it probably requires the python ports from https://github.com/Neumann-A/my-vcpkg-ports (e.g. https://github.com/Neumann-A/my-vcpkg-ports/tree/master/python-setuptools)

@dg0yt
Copy link
Contributor Author

dg0yt commented Jan 25, 2024

Hm.
Maybe it would still be better to have a single recipe with known limitations than n uncoordinated attempts with unknown maturity.

Copy link

github-actions bot commented Mar 8, 2024

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 28 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Mar 8, 2024
@dg0yt
Copy link
Contributor Author

dg0yt commented Mar 8, 2024

Needs to be resolved.

@github-actions github-actions bot removed the Stale label Mar 9, 2024
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 28 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@Cheney-W
Copy link
Contributor

Stay active

JavierMatosD pushed a commit that referenced this issue Apr 29, 2024
closes #36801
closes #36253
closes #36044

~~includes #24327 to fix dlib linkage in the osx pipelines.~~ 

Need to look at 
~~#36044~~
~~#36345~~

merge after 
- [x] #37561

---------

Co-authored-by: Alexander Neumann <you@example.com>
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:question This issue is a question Stale
Projects
None yet
Development

No branches or pull requests

3 participants