Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blend2d] Update to beta_2020-04-19 #10891

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Conversation

ZeeWanderer
Copy link
Contributor

@ZeeWanderer ZeeWanderer commented Apr 18, 2020

How do i go about adding natvis file to visualizers dir? I can add instructions to usage but i think this should be automated.
ImageWatch extension requires natvis file to be resent in visualizers dir as it cannot be loaded from .pdb in this case.

@ZeeWanderer ZeeWanderer changed the title [blend2d] Update to beta_2020-04-18 [WIP][blend2d] Update to beta_2020-04-18 Apr 18, 2020
@ZeeWanderer ZeeWanderer changed the title [WIP][blend2d] Update to beta_2020-04-18 [blend2d] Update to beta_2020-04-18 Apr 18, 2020
@ZeeWanderer ZeeWanderer changed the title [blend2d] Update to beta_2020-04-18 [blend2d] Update to beta_2020-04-19 Apr 19, 2020
@JackBoosY
Copy link
Contributor

JackBoosY commented Apr 20, 2020

The otl regressions(#10922) are not related with this PR.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 21, 2020
@JackBoosY
Copy link
Contributor

LGTM, thanks for this PR!

@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

As for natviz files, we don't have an automated way of doing this other than putting them in the .pdb. You can put them in share\blend2d\ and they'll at least be available for the user to install into the visualizers dir if they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants