Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline] Update hash for otl #10922

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

NancyLi1013
Copy link
Contributor

otl failed on current CI due to wrong hash. I can also reproduce this on my local machine.

The errors like this:

-- Using cached C:/vsts/_work/4/s/downloads/otlv4_40451.zip
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:99 (message):
  

  File does not have expected hash:

          File path: [ C:/vsts/_work/4/s/downloads/otlv4_40451.zip ]
      Expected hash: [ add1e54fae20175461d5f09cbe324e98b6f6a3839356136811109cf3251ca96541c101816870c6cc15d7611ad6bf9d576ac8dfce4274419b30866955c5892d15 ]
        Actual hash: [ 74499b79a756c1ecc16d6bd9b277b91add55249d2e1cb65a31786e9750ff607da1222797f318954599efc5153cecee2d3a7fd1e994c09e7ddb2507c8e5ce5c55 ]

  Please delete the file and retry if this file should be downloaded again.

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:110 (test_hash)
  ports/otl/portfile.cmake:3 (vcpkg_download_distfile)
  scripts/ports.cmake:90 (include)

So I update the hash to fix this.

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Apr 20, 2020
@JackBoosY JackBoosY mentioned this pull request Apr 20, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 20, 2020
@BillyONeal
Copy link
Member

Note that this change was also applied to #10828 but I did not bump the package version number. I'm guessing that the only thing they changed was the copyright date on the header.

@vicroms vicroms merged commit b716aa1 into microsoft:master Apr 20, 2020
@c72578
Copy link
Contributor

c72578 commented Apr 21, 2020

The contents of the packed file otlv40451.h inside otlv4_40451.zip stayed exactly the same. However, the file modification date of otlv40451.h was changed by one hour, causing a difference in the zip file and therefore different SHA512 hashes. It seems, that it was zip packed again after switching to summer time/Daylight saving time (DST).

Original, released zip file:
otlv4_40451.zip
SHA512: add1e54fae20175461d5f09cbe324e98b6f6a3839356136811109cf3251ca96541c101816870c6cc15d7611ad6bf9d576ac8dfce4274419b30866955c5892d15

Current, modified zip file:
otlv4_40451_modified_2020-03-27.zip
SHA512: 74499b79a756c1ecc16d6bd9b277b91add55249d2e1cb65a31786e9750ff607da1222797f318954599efc5153cecee2d3a7fd1e994c09e7ddb2507c8e5ce5c55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants