Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wavelib] Add new port #11611

Merged
merged 7 commits into from
Jun 1, 2020
Merged

[wavelib] Add new port #11611

merged 7 commits into from
Jun 1, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented May 27, 2020

Describe the pull request

@LilyWangL
Copy link
Contributor

Thanks for your PR. Now this port build failed on UWP with the error:

buildtrees\wavelib\src\eca7ffb5b8-4cc354026a\src\wavelib.c(3673): error C4703: potentially uninitialized local pointer variable 'out' used [C:\agent\_work\2\s\buildtrees\wavelib\x64-uwp-dbg\src\wavelib.vcxproj]
buildtrees\wavelib\src\eca7ffb5b8-4cc354026a\src\wavelib.c(3499): error C4703: potentially uninitialized local pointer variable 'wavecoeff' used [C:\agent\_work\2\s\buildtrees\wavelib\x64-uwp-dbg\src\wavelib.vcxproj]

@myd7349 myd7349 marked this pull request as ready for review May 29, 2020 02:39
@myd7349 myd7349 mentioned this pull request May 29, 2020
Merged
@myd7349
Copy link
Contributor Author

myd7349 commented May 29, 2020

Thanks for your PR. Now this port build failed on UWP with the error:

buildtrees\wavelib\src\eca7ffb5b8-4cc354026a\src\wavelib.c(3673): error C4703: potentially uninitialized local pointer variable 'out' used [C:\agent\_work\2\s\buildtrees\wavelib\x64-uwp-dbg\src\wavelib.vcxproj]
buildtrees\wavelib\src\eca7ffb5b8-4cc354026a\src\wavelib.c(3499): error C4703: potentially uninitialized local pointer variable 'wavecoeff' used [C:\agent\_work\2\s\buildtrees\wavelib\x64-uwp-dbg\src\wavelib.vcxproj]

Hi! @LilyWangL Thanks. Done.

@LilyWangL LilyWangL added category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines labels May 29, 2020
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels May 29, 2020
@dan-shaw dan-shaw merged commit 4cc5ac5 into microsoft:master Jun 1, 2020
@myd7349 myd7349 deleted the wavelib-init branch June 2, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myd7349 @LilyWangL @dan-shaw