fix UWP build error #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix the following UWP build errors caught by vcpkg's CI src\wavelib.c(3673): error C4703: potentially uninitialized local pointer variable 'out' used src\wavelib.c(3499): error C4703: potentially uninitialized local pointer variable 'wavecoeff' used - move the definition of `out` variable to support old C89 compilers;
|
This patch also removes redundant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was trying to add
wavelibintovcpkgrecently: microsoft/vcpkg#11611. And the CI system ofvcpkgreports build failures onx64-uwpandarm-uwp. The build logs can be downloaded from here: https://dev.azure.com/vcpkg/public/_build/results?buildId=37972&view=artifacts&type=publishedArtifactsThis patch tries to:
src\wavelib.c(3673): error C4703: potentially uninitialized local pointer variable 'out' used
src\wavelib.c(3499): error C4703: potentially uninitialized local pointer variable 'wavecoeff' used
outvariable to support old C89 compilers;That way, I can use wavelib with VS2010.