Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fp16] create a new port #16340

Merged
merged 6 commits into from
Apr 1, 2021
Merged

[fp16] create a new port #16340

merged 6 commits into from
Apr 1, 2021

Conversation

luncliff
Copy link
Contributor

What does your PR fix?

There was no port request for this project.

This is one of the 3rd party libraries for the PyTorch project. The PR will be used for future support of the libtorch port.

Which triplets are supported/not supported? Have you updated the CI baseline?

This port is a header-only library, so every triplet must be available.

Does your PR follow the maintainer guide?

The library doesn't have a tag/release.

@luncliff luncliff marked this pull request as draft February 21, 2021 08:06
@luncliff
Copy link
Contributor Author

luncliff commented Feb 21, 2021

This PR will be rebased when #16339 is merged. To prevent merge, it will remain in the draft mode.

@luncliff luncliff mentioned this pull request Feb 21, 2021
3 tasks
@NancyLi1013 NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed labels Feb 22, 2021
@luncliff luncliff marked this pull request as ready for review February 25, 2021 01:27
@NancyLi1013 NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Feb 25, 2021
ports/fp16/portfile.cmake Outdated Show resolved Hide resolved
ports/fp16/vcpkg.json Outdated Show resolved Hide resolved
versions/f-/fp16.json Outdated Show resolved Hide resolved
ports/fp16/vcpkg.json Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 1, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for adding this new port @luncliff.

@vicroms vicroms merged commit 67d8f45 into microsoft:master Apr 1, 2021
@luncliff luncliff deleted the port/fp16 branch April 2, 2021 01:04
@luncliff luncliff mentioned this pull request Apr 10, 2021
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants