Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnpack] create a new port #16344

Merged
merged 17 commits into from
Apr 7, 2021
Merged

[nnpack] create a new port #16344

merged 17 commits into from
Apr 7, 2021

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Feb 21, 2021

What does your PR fix?

There was no port request for this project.

This is one of the 3rd party libraries for the PyTorch project. The PR will be used for future support of the libtorch port.

Which triplets are supported/not supported? Have you updated the CI baseline?

Looks like it supports Linux, Mac, iOS, and Android. The PR targets only 2 triplets.

  • x64-osx
  • x64-linux

The project doesn't have a configuration for Windows. (WIN32, AMD64, CMAKE_SYSTEM_NAME, etc.)

Does your PR follow the maintainer guide?

The library doesn't have a tag/release.

@luncliff luncliff changed the title Port/nnpack [nnpack] create a new port Feb 21, 2021
@luncliff luncliff marked this pull request as draft February 21, 2021 09:05
@luncliff
Copy link
Contributor Author

The port will be rebased after the merge of #16340 #16342.

@JackBoosY JackBoosY added category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed labels Feb 22, 2021
* there are no config for windows
There is a 'neon' backend, but it won't be considered for now
@luncliff luncliff marked this pull request as ready for review April 3, 2021 16:55
* use more correct expression
@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 5, 2021
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

LGTM, already tested on Linux and OSX, curious why the CI status is N/A.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 5, 2021
@vicroms vicroms merged commit e1f1938 into microsoft:master Apr 7, 2021
@luncliff luncliff deleted the port/nnpack branch April 8, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants