Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qnnpack] create a new port #17065

Merged
merged 10 commits into from
May 7, 2021
Merged

[qnnpack] create a new port #17065

merged 10 commits into from
May 7, 2021

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Apr 3, 2021

What does your PR fix?

There was no port request for this project.

This is one of the 3rd party libraries for the PyTorch project. The PR will be used for future support of the libtorch port.

Related Works

Which triplets are supported/not supported? Have you updated the CI baseline?

The project's CI only considers linux and osx.

  • x64-osx
  • x64-linux

Does your PR follow the maintainer guide?

Yes.

* the project only checks linux/osx
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 5, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luncliff, thanks for the PR!

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luncliff, you need add vcpkg-cmake to dependency.

You can reference similar PR #17101

luncliff and others added 3 commits April 10, 2021 17:40
Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
@luncliff
Copy link
Contributor Author

Applied vcpkg-cmake in 75e1f36. But #17063 may break this port.
I will take care of it if this PR is merged first.

@luncliff luncliff requested a review from PhoebeHui April 10, 2021 08:52
@PhoebeHui PhoebeHui added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Apr 12, 2021
@PhoebeHui
Copy link
Contributor

We should rerun this PR after PR #17063 merged.

@PhoebeHui PhoebeHui removed the depends:different-pr This PR or Issue depends on a PR which has been filed label May 6, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2021
@BillyONeal BillyONeal merged commit 2b1f2ca into microsoft:master May 7, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution!

@luncliff luncliff deleted the port/qnnpack branch May 7, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants