Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stduuid] Adding new port stduuid #16382

Merged
merged 9 commits into from
Sep 14, 2021
Merged

[stduuid] Adding new port stduuid #16382

merged 9 commits into from
Sep 14, 2021

Conversation

dave-juicelabs
Copy link
Contributor

Adds the stduuid project which is a proposal to add uuid support to std.

@ghost
Copy link

ghost commented Feb 23, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 24, 2021
@NancyLi1013
Copy link
Contributor

Hi @dave-juicelabs

Thanks for your PR.

Seems the format of vcpkg.json is not correct. Could you please check it again?

Also you can run ./vcpkg format-manifest ports/stduuid/vcpkg.json to format it.

NancyLi1013
NancyLi1013 suggested changes Feb 24, 2021
View reviewed changes
ports/stduuid/portfile.cmake Outdated Show resolved Hide resolved
ports/stduuid/vcpkg.json Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

The failures on x86-windows:

Error: While validating port stduuid.
       Missing expected versions file at: C:\a\1\s\versions\s-\stduuid.json
       Run:

           vcpkg x-add-version stduuid

       to create the versions file.

Please run ./vcpkg x-add-version stduuid and then submit the changes for versions.

dave-juicelabs pushed a commit to Juice-Labs/vcpkg that referenced this pull request Feb 25, 2021
@damcclos
[stduuid] Making changes requested in pull request microsoft#16382.
61f4ead
@NancyLi1013
Copy link
Contributor

@dave-juicelabs

Have you tested these features in this PR?

@dave-juicelabs
Copy link
Contributor Author

Yes, I am actively using these changes.

@NancyLi1013
Copy link
Contributor

LGTM now, thanks for adding the new port @dave-juicelabs.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Mar 5, 2021
vicroms
vicroms requested changes Apr 7, 2021
View reviewed changes
ports/stduuid/vcpkg.json Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 8, 2021
NancyLi1013
NancyLi1013 suggested changes Apr 8, 2021
View reviewed changes
ports/stduuid/portfile.cmake Outdated Show resolved Hide resolved
versions/s-/stduuid.json Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

Could you please address the review suggestion again? @dave-juicelabs

@NancyLi1013
Copy link
Contributor

Could you please run vcpkg x-add-version stduuid --overwrite-version to solve the failures on x86-windows?

NancyLi1013
NancyLi1013 suggested changes Jul 19, 2021
View reviewed changes
ports/folly/portfile.cmake Outdated Show resolved Hide resolved
ports/stduuid/portfile.cmake Outdated Show resolved Hide resolved
ports/stduuid/portfile.cmake Outdated Show resolved Hide resolved
ports/stduuid/portfile.cmake Outdated Show resolved Hide resolved
ports/stduuid/portfile.cmake Outdated Show resolved Hide resolved
ports/stduuid/vcpkg.json Show resolved Hide resolved
@dave-juicelabs dave-juicelabs force-pushed the Juice-2020.11-1 branch 2 times, most recently from 25f2da4 to 0f8348d Compare August 28, 2021 12:28
NancyLi1013
NancyLi1013 suggested changes Aug 30, 2021
View reviewed changes
ports/stduuid/vcpkg.json Outdated Show resolved Hide resolved
ports/stduuid/portfile.cmake Outdated Show resolved Hide resolved
ports/stduuid/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 13, 2021
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Sep 13, 2021
@BillyONeal BillyONeal merged commit e201002 into microsoft:master Sep 14, 2021
@BillyONeal
Copy link
Member

Thanks for the new port :D

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Sep 14, 2021
@BillyONeal
Revert "[stduuid] Adding new port stduuid (microsoft#16382)"
358234e 
This reverts commit e201002.
BillyONeal added a commit that referenced this pull request Sep 14, 2021
@BillyONeal
Revert "[stduuid] Adding new port stduuid (#16382)" (#20161)
cf2f757 
This reverts commit e201002.
@BillyONeal
Copy link
Member

This broke CI last night and we discovered issues, so it was reverted in #20161 . If you still want this library, please consider creating a new PR with changes similar to those in BillyONeal@474b10f

Notes:

  • gsl must be provided by the ms-gsl port, not by this port.
  • The span polyfill must be baked into the installed tree as perhttps://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#a-feature-may-replace-polyfills-with-aliases-provided-that-replacement-is-baked-into-the-installed-tree and enabling the feature must enable the polyfill, not remove it.
  • (I gave up trying to fix it here) the port must work in all of the feature modes; in my testing the port never includes <gsl/span> but expects gsl::span to be present.

@dave-juicelabs dave-juicelabs deleted the Juice-2020.11-1 branch November 17, 2021 19:50
@PhoebeHui PhoebeHui mentioned this pull request Dec 14, 2021
Closed
@ankurvdev ankurvdev mentioned this pull request Jan 22, 2022
Closed
@BurningEnlightenment BurningEnlightenment mentioned this pull request Jun 7, 2022
Merged
Sungeun0318 pushed a commit to Sungeun0318/-vcpkg that referenced this pull request May 15, 2024
@dave-juicelabs @damcclos
@NancyLi1013 @mheyman
[stduuid] Adding new port stduuid (#16382)
d573daf 
* [stduuid] Adding new port stduuid

* [stduuid] Making changes requested in pull request #16382.

* [stduuid] Changes from vcpkg x-add-version

* Update versions/s-/stduuid.json

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

* Update ports/stduuid/portfile.cmake

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

* [stduuid] Changes from .\vcpkg.exe x-add-version stduuid --overwrite-version.

* [stduuid] Changes requested from microsoft/vcpkg#16382.

* [stduuid] Adding changes requested during PR.

* [stduuid] Updating version.

Co-authored-by: David McCloskey <davmcclo@gmail.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Sungeun0318 pushed a commit to Sungeun0318/-vcpkg that referenced this pull request May 15, 2024
@dave-juicelabs @damcclos
@NancyLi1013 @yourWaifu
[stduuid] Adding new port stduuid (#16382)
e5557e1 
* [stduuid] Adding new port stduuid

* [stduuid] Making changes requested in pull request #16382.

* [stduuid] Changes from vcpkg x-add-version

* Update versions/s-/stduuid.json

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

* Update ports/stduuid/portfile.cmake

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

* [stduuid] Changes from .\vcpkg.exe x-add-version stduuid --overwrite-version.

* [stduuid] Changes requested from microsoft/vcpkg#16382.

* [stduuid] Adding changes requested during PR.

* [stduuid] Updating version.

Co-authored-by: David McCloskey <davmcclo@gmail.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@vicroms vicroms vicroms requested changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dave-juicelabs @NancyLi1013 @BillyONeal @vicroms @damcclos