Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stduuid] Add new port @1.2.2 #25115

Merged

Conversation

BurningEnlightenment
Copy link
Contributor

Describe the pull request

I tried to address the issues of #16382 that were raised by @BillyONeal and lead to its revert in #20161.

@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 8, 2022
@JonLiu1993
Copy link
Member

@BurningEnlightenment ,Thanks for your pr, when I tested the features locally by run command "./vcpkg install stduuid[*]:x64-windows" but failed:

Stored binary cache: C:\Users\test\AppData\Local\vcpkg\archives\3a\3aeb5f916ec5358eb5a509ef887e2f36dd9128b010edf877c7bedda9dc561293.zip
The following files are already installed in F:/Feature-test/stduuid/vcpkg/installed/x86-windows and are in conflict with stduuid:x86-windows

Installed by ms-gsl:x86-windows
    include/gsl/gsl
    include/gsl/gsl_algorithm
    include/gsl/gsl_assert
    include/gsl/gsl_byte
    include/gsl/gsl_util
    include/gsl/pointers
    include/gsl/span
    include/gsl/string_span

Please ensure you're using the latest port files with `git pull` and `vcpkg update`.

when I run command "./vcpkg install stduuid[*]:x64-linux" also failed:

OT_DIR=/home/test/test/vcpkg -D_VCPKG_INSTALLED_DIR=/home/test/test/vcpkg/installed -DVCPKG_MANIFEST_INSTALL=OFF
    Working Directory: /home/test/test/vcpkg/buildtrees/stduuid/x64-linux-rel
    Error code: 1
    See logs for more information:
      /home/test/test/vcpkg/buildtrees/stduuid/config-x64-linux-rel-out.log
      /home/test/test/vcpkg/buildtrees/stduuid/config-x64-linux-rel-err.log

Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:355 (vcpkg_execute_required_process)
  ports/stduuid/portfile.cmake:19 (vcpkg_cmake_configure)
  scripts/ports.cmake:146 (include)

/home/test/test/vcpkg/buildtrees/stduuid/config-x64-linux-rel-err.log

CMake Error at cmake/FindLibuuid.cmake:11 (message):
  Could NOT find libuuid
Call Stack (most recent call first):
  /home/test/test/vcpkg/scripts/buildsystems/vcpkg.cmake:824 (_find_package)
  CMakeLists.txt:25 (find_package)

@BurningEnlightenment
Copy link
Contributor Author

BurningEnlightenment commented Jun 8, 2022

"./vcpkg install stduuid[*]:x64-windows" but failed

I forgot to reference the patch from vcpkg_from_github(), sorry.

"./vcpkg install stduuid[*]:x64-linux" also failed

I just added a patch that integrates this package with the libuuid port.

@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 8, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

ports/stduuid/fix-libuuid-dependency.patch Show resolved Hide resolved
ports/stduuid/portfile.cmake Show resolved Hide resolved
ports/stduuid/portfile.cmake Show resolved Hide resolved
ports/stduuid/vcpkg.json Outdated Show resolved Hide resolved
ports/stduuid/vcpkg.json Show resolved Hide resolved
@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label Jun 9, 2022
@BurningEnlightenment
Copy link
Contributor Author

This is ready for the next review round.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 14, 2022
@vicroms vicroms merged commit 3d054a1 into microsoft:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcpkg problem [New Port Request] stduuid
6 participants