-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stduuid] Add new port @1.2.2 #25115
[stduuid] Add new port @1.2.2 #25115
Conversation
@BurningEnlightenment ,Thanks for your pr, when I tested the features locally by run command "./vcpkg install stduuid[*]:x64-windows" but failed:
when I run command "./vcpkg install stduuid[*]:x64-linux" also failed:
/home/test/test/vcpkg/buildtrees/stduuid/config-x64-linux-rel-err.log
|
396ec9a
to
3cc0cd8
Compare
3cc0cd8
to
0a77791
Compare
I forgot to reference the patch from
I just added a patch that integrates this package with the |
All features are tested successfully in the following triplet:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
0a77791
to
737a38e
Compare
737a38e
to
09ceee5
Compare
This is ready for the next review round. |
Describe the pull request
I tried to address the issues of #16382 that were raised by @BillyONeal and lead to its revert in #20161.
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes