Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pistache] Delete the port. #19181

Closed
wants to merge 3 commits into from

Conversation

BillyONeal
Copy link
Member

The port "pistache" was only installing its verdored copy of rapidjson, it wasn't actually installing anything related to itself. As a result, if rapidjson was already installed by vcpkg, and the port tried to use the one provided by vcpkg, nothing at all would be installed. There is no evidence that anyone actually used this port. The upstream project does not have proper cmake bindings set up, and it will require substantial modification of their build system to repair.

As a result, this change just deletes the port. It is likely that someone could add it back later in terms of meson, which seems to be the buildsystem preferred upstream.

The port "pistache" was only installing its verdored copy of rapidjson, it wasn't actually installing anything related to itself. As a result, if rapidjson was already installed by vcpkg, and the port tried to use the one provided by vcpkg, nothing at all would be installed. There is no evidence that anyone actually used this port. The upstream project does not have proper cmake bindings set up, and it will require substantial modification of their build system to repair.

As a result, this change just deletes the port. It is likely that someone could add it back later in terms of meson, which seems to be the buildsystem preferred upstream.
@BillyONeal BillyONeal added the category:port-bug The issue is with a library, which is something the port should already support label Jul 28, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 1257354a3ab0bebd8abe95281ca561537853578c -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 0e38132..a5bfbc3 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4888,6 +4888,10 @@
       "baseline": "2019-07-11",
       "port-version": 0
     },
+    "pistache": {
+      "baseline": "2021-03-31",
+      "port-version": 1
+    },
     "pixel": {
       "baseline": "0.3-1",
       "port-version": 0

@PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui added the info:internal This PR or Issue was filed by the vcpkg team. label Jul 28, 2021
@PhoebeHui PhoebeHui mentioned this pull request Jul 28, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 1257354a3ab0bebd8abe95281ca561537853578c -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 0e38132..a5bfbc3 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4888,6 +4888,10 @@
       "baseline": "2019-07-11",
       "port-version": 0
     },
+    "pistache": {
+      "baseline": "2021-03-31",
+      "port-version": 1
+    },
     "pixel": {
       "baseline": "0.3-1",
       "port-version": 0

@strega-nil-ms
Copy link
Contributor

This is probably not the correct solution. We should instead roll back pistache, since pistache itself is not broken, the new version added was broken.

@strega-nil-ms
Copy link
Contributor

Closing in favor of #19206

@BillyONeal
Copy link
Member Author

This is probably not the correct solution. We should instead roll back pistache, since pistache itself is not broken, the new version added was broken.

It looks like it was always broken. But if you know how to fix it I agree that's better.

Closing in favor of #19206

Sounds great!

@BillyONeal BillyONeal deleted the delete-pistache branch July 28, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants