-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg-cmake] Fix vcpkg_copy_pdbs false alarm #19369
Conversation
The baseline issue would be fixed by #19361. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I think something breaks the pipeline test. |
The CI errors seem unrelated.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks exactly like PR I have proposed at #19462, I have tested it and it should really be dlls_without_matching_pdbs
, so I can approve this.
@dan-shaw, could you help merge this PR? |
Thanks for fixing my bug @myd7349 :) |
[vcpkg-cmake] Fix vcpkg_copy_pdbs false alarm (microsoft#19369)
Describe the pull request
What does your PR fix?
Fixes #...
Which triplets are supported/not supported? Have you updated the CI baseline?
<all / linux, windows, ...>, <Yes/No>
Does your PR follow the maintainer guide?
Your answer
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?<Yes / I am still working on this PR>
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/