Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-cmake] Fix vcpkg_copy_pdbs false alarm #19369

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Aug 5, 2021

Describe the pull request

  • What does your PR fix?

    Fixes #...

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>

  • Does your PR follow the maintainer guide?

    Your answer

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    <Yes / I am still working on this PR>

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@JackBoosY JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Aug 5, 2021
@myd7349 myd7349 marked this pull request as ready for review August 5, 2021 05:03
@PhoebeHui
Copy link
Contributor

The baseline issue would be fixed by #19361.

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@PhoebeHui PhoebeHui requested a review from strega-nil-ms August 5, 2021 10:04
@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

I think something breaks the pipeline test.

@dg0yt
Copy link
Contributor

dg0yt commented Aug 9, 2021

I think something breaks the pipeline test.

The CI errors seem unrelated.

  • ptex:x86-windows had issues before, cf. [vcpkg] Honor CMAKE_DISABLE_FIND_PACKAGE_*. Fixes #18631 #18961. Maybe it isn't triggered often enough in CI.
  • The rbdl-orb problems are not original build errors (no failure logs!), but duplicate installations with port rbdl. Interesting: They happened only x86-compatible windows builds other native x64-windows.

@PhoebeHui
Copy link
Contributor

PhoebeHui commented Aug 9, 2021

@dg0yt, thanks for your comments! the baseline issue would be fixed by #19453.

Copy link
Contributor

@silverqx silverqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks exactly like PR I have proposed at #19462, I have tested it and it should really be dlls_without_matching_pdbs, so I can approve this.

@PhoebeHui PhoebeHui removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 10, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 10, 2021
@PhoebeHui
Copy link
Contributor

@dan-shaw, could you help merge this PR?

@PhoebeHui PhoebeHui requested a review from dan-shaw August 10, 2021 07:40
@strega-nil-ms strega-nil-ms merged commit 69478c5 into microsoft:master Aug 10, 2021
@strega-nil-ms
Copy link
Contributor

Thanks for fixing my bug @myd7349 :)

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Aug 10, 2021
[vcpkg-cmake] Fix vcpkg_copy_pdbs false alarm (microsoft#19369)
@myd7349 myd7349 deleted the fix-vcpkg-copy-pdbs branch August 10, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants