bugfix unmatched dlls in vcpkg_copy_pdbs #19462
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
if
condition to check unmatcheddlls
.Currently, the
unmatched_dlls_length
variable is used, but this variable is not defined anywhere, it should bedlls_without_matching_pdbs
.What does your PR fix?
Currently, if you use
vcpkg_copy_pdbs()
, then following condition is alwaystrue
becauseunmatched_dlls_length
doesn't exist and because of that the vcpkg output contains this error message everytime: