Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix unmatched dlls in vcpkg_copy_pdbs #19462

Closed
wants to merge 1 commit into from
Closed

bugfix unmatched dlls in vcpkg_copy_pdbs #19462

wants to merge 1 commit into from

Conversation

silverqx
Copy link
Contributor

@silverqx silverqx commented Aug 9, 2021

Fix if condition to check unmatched dlls.

Currently, the unmatched_dlls_length variable is used, but this variable is not defined anywhere, it should be dlls_without_matching_pdbs.

  • What does your PR fix?

Currently, if you use vcpkg_copy_pdbs(), then following condition is always true because unmatched_dlls_length doesn't exist and because of that the vcpkg output contains this error message everytime:

CMake Warning at scripts/cmake/vcpkg_copy_pdbs.cmake:70 (message):
  Could not find a matching pdb file for:


Call Stack (most recent call first):
  ports/hello-world-library/portfile.cmake:57 (vcpkg_copy_pdbs)
  scripts/ports.cmake:141 (include)

Fix if condition to check unmatched dll.
@cenit
Copy link
Contributor

cenit commented Aug 9, 2021

duplicate of #19369 ?

@silverqx
Copy link
Contributor Author

silverqx commented Aug 9, 2021

It is @cenit, so I have approved #19369 and closing this PR.

@silverqx silverqx closed this Aug 9, 2021
@silverqx silverqx deleted the silverqx-patch-1 branch August 11, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants