Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][qpid-proton] Fix dependencies #24267

Merged
merged 7 commits into from
Apr 21, 2022
Merged

[vcpkg baseline][qpid-proton] Fix dependencies #24267

merged 7 commits into from
Apr 21, 2022

Conversation

JackBoosY
Copy link
Contributor

Fix:

CMake Error at tools/cmake/Modules/FindPython.cmake:28 (message):
  Both PYTHON_EXECUTABLE and Python_EXECUTABLE are defined.  Define at most
  one of those.

Also fix other dependencies.

Related: #23259 #24100

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 20, 2022
JackBoosY added 2 commits April 20, 2022 04:19
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Apr 20, 2022
@Neumann-A Neumann-A mentioned this pull request Apr 20, 2022
Closed
@strega-nil-ms strega-nil-ms force-pushed the dev/jack/fix-baseline-20220420 branch from 7265600 to 9313087 Compare April 20, 2022 23:09
@strega-nil-ms
Copy link
Contributor

I really didn't like the fixes in this or #24282, so I did my own fix

github-actions[bot]
github-actions bot requested changes Apr 20, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qpid-proton but no changes to version or port version.
-- Version: 0.37.0#1
-- Old SHA: 62d99c883f70d3e43b1ed7bcf03d1c3664fa0002
-- New SHA: 543baa82530f5eb5ed9b3d6348a14b5e24ccda64
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JackBoosY JackBoosY mentioned this pull request Apr 21, 2022
Merged
@strega-nil-ms
Copy link
Contributor

Thanks y'all!

@strega-nil-ms strega-nil-ms merged commit 3f2dfb8 into microsoft:master Apr 21, 2022
@JackBoosY JackBoosY deleted the dev/jack/fix-baseline-20220420 branch April 21, 2022 16:23
This was referenced Apr 21, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @strega-nil-ms @LilyWangLL @strega-nil