Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vcpkg-tool to 2022-05-05 #24526

Merged
merged 3 commits into from
May 10, 2022
Merged

Update vcpkg-tool to 2022-05-05 #24526

merged 3 commits into from
May 10, 2022

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented May 4, 2022 •
edited
Loading

@BillyONeal
Copy link
Member Author

I backed out the #23477 parts for now because:

image

I will work on making sure this works better after resurrection of #23753

@BillyONeal BillyONeal changed the title Update vcpkg-tool to 2022-05-03 Update vcpkg-tool to 2022-05-05 May 5, 2022
@JackBoosY JackBoosY self-assigned this May 5, 2022
@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels May 5, 2022
@BillyONeal BillyONeal marked this pull request as draft May 5, 2022 02:21
@BillyONeal BillyONeal marked this pull request as ready for review May 5, 2022 02:21
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 5, 2022
@BillyONeal
Copy link
Member Author

Not merging this one despite "reviewed" because there are corresponding changes in the "catalog" repo that have to land at the same time.

@BillyONeal BillyONeal merged commit 14e7bb4 into microsoft:master May 10, 2022
@BillyONeal BillyONeal deleted the update-tool branch May 10, 2022 22:55
@BillyONeal BillyONeal mentioned this pull request May 11, 2022
Closed
@dg0yt dg0yt mentioned this pull request Jun 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyONeal @JackBoosY