Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xunit output errors, trim result list #585

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jun 11, 2022

Fixes microsoft/vcpkg#24526 (comment),
Error: 'method' is a duplicate attribute name.

In today's tool output I found this pattern:

<test name="elfutils:x64-linux" method="elfutils[core]:x64-linux" time="11" method="Fail">

where I expected this pattern:

<test name="abseil:x64-windows" method="abseil[core]:x64-windows" time="13" result="Pass">

@dg0yt dg0yt changed the title Fix duplicate method attribute Fix xunit output errors Jun 11, 2022
@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 11, 2022

And this:
The 'message' start tag on line 10840 position 19 does not match the end tag of 'failure'. Line 10840, position 53

<failure><message><![CDATA[FILE_CONFLICTS]]></failure></message>

@dg0yt dg0yt marked this pull request as draft June 12, 2022 06:05
@dg0yt dg0yt changed the title Fix xunit output errors Fix xunit output errors, trim result list Jun 12, 2022
@dg0yt dg0yt marked this pull request as ready for review June 12, 2022 09:25
@BillyONeal BillyONeal merged commit bc77ae7 into microsoft:main Jun 13, 2022
@BillyONeal
Copy link
Member

Thanks for the fix!

@dg0yt dg0yt deleted the ci-xml branch June 14, 2022 03:51
BillyONeal added a commit to microsoft/vcpkg that referenced this pull request Jun 15, 2022
* Update vcpkg-tool to 2022-06-15. See https://github.com/microsoft/vcpkg-tool/releases/tag/2022-06-15
* Add `=pass` entries from microsoft/vcpkg-tool#579
* Cherry pick XUnit output from #23477 which hooks up microsoft/vcpkg-tool#585 (Thanks again @dg0yt !)
* Update release process document now that we can do the full tree rebuild to test the tool release before signing.

Thank you:

@autoantwort 
@christophe-calmejane 
@JackBoosY 
@benmcmorran
@hmoffatt 
@klalumiere 
@Thomas1664 
@Neumann-A 
@AenBleidd

for your contributions!

Fixes #22686 .
Fixes #21800 .
Fixes #16216 .
Fixes #15836 .

Full tree rebuild testing this update is: https://dev.azure.com/vcpkg/public/_build/results?buildId=73664&view=results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants