Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcpkg-tool to 2022-06-15 #25226

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Jun 14, 2022

Thank you:

@autoantwort
@christophe-calmejane
@JackBoosY
@benmcmorran
@hmoffatt
@klalumiere
@Thomas1664
@Neumann-A
@AenBleidd

for your contributions!

Fixes #22686 .
Fixes #21800 .
Fixes #16216 .
Fixes #15836 .

Full tree rebuild testing this update is: https://dev.azure.com/vcpkg/public/_build/results?buildId=73664&view=results

@BillyONeal BillyONeal added the info:internal This PR or Issue was filed by the vcpkg team. label Jun 14, 2022
@JonLiu1993 JonLiu1993 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jun 14, 2022
@BillyONeal BillyONeal changed the title Update vcpkg-tool Update vcpkg-tool to 2022-06-15 Jun 15, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for librttopo have changed but the version was not updated
version: 1.1.0#5
old SHA: d747c88d429ff781b11627623d0958967f912a41
new SHA: 144a5d16e71f2ceec96373e3f26b71d704bb9bec
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@BillyONeal BillyONeal marked this pull request as ready for review June 15, 2022 06:10
@BillyONeal
Copy link
Member Author

BillyONeal commented Jun 15, 2022

Fixes #22686 .
Fixes #21800 .
Fixes #16216 .
Fixes #15836 .

@dg0yt
Copy link
Contributor

dg0yt commented Jun 15, 2022

This includes the simulated build error for librttopo. Before reverting this change I would like to see a test for another new feature, by temporarily adding spatialite-tools:x64-windows = pass to the CI baseline, to be triggered by simulated error.

@BillyONeal
Copy link
Member Author

This includes the simulated build error for librttopo.

Yep, already sucked it out into its own commit so that it can be force-pushed off. It works! Thank you!
image

Before reverting this change I would like to see a test for another new feature, by temporarily adding spatialite-tools:x64-windows = pass to the CI baseline, to be triggered by simulated error.

Stand by...

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for librttopo have changed but the version was not updated
version: 1.1.0#5
old SHA: d747c88d429ff781b11627623d0958967f912a41
new SHA: 144a5d16e71f2ceec96373e3f26b71d704bb9bec
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@BillyONeal
Copy link
Member Author

Before reverting this change I would like to see a test for another new feature, by temporarily adding spatialite-tools:x64-windows = pass to the CI baseline, to be triggered by simulated error.

Stand by...

Does not show in the xunit output but does show on the terminal:

image

@dg0yt
Copy link
Contributor

dg0yt commented Jun 15, 2022

Does not show in the xunit output but does show on the terminal

Yes. IMO it is good enough for now. But it should be turned into an error in vcpkg tool xunit output, aligning console output with xunit. (It is possibly that this is the only error, so it should be a formal error in xunit output even if not "run".)

@BillyONeal
Copy link
Member Author

@cenit I know you were looking for this =pass feature @ras0219-msft implemented.

@BillyONeal BillyONeal merged commit 0abb2b2 into microsoft:master Jun 15, 2022
@BillyONeal BillyONeal deleted the tool-update branch June 15, 2022 18:20
@cenit
Copy link
Contributor

cenit commented Jun 15, 2022

@cenit I know you were looking for this =pass feature @ras0219-msft implemented.

wonderful, thanks.
I have been busy recently in many other projects, glad to see very nice improvements here in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
6 participants