[cpuinfo] Fix cpuid-dump is not generated with x86-windows

[Cheney-W]

Describe the pull request

• What does your PR fix?

  Fixes [cpuinfo] Build error #24713

  1. Modify portfile.cmake to pass the correct values.
  2. Add a condition to make the option to use the value passed by portfile.cmake under windows.

[BillyONeal]

Can you explain what this patch does? Has upstream been notified?

(Normally I wouldn't have questions like that about what look like relatively simple build system changes, but this port is literally cpuinfo so it likely cares a lot about the specific CPU it wants to target)

[Cheney-W]

I added this patch to make following part set in portfile.cmake take effect in cmakelist.txt of source:

set(CPUINFO_TARGET_PROCESSOR_param "")
if(VCPKG_TARGET_IS_WINDOWS)
    # NOTE: arm64-windows is unsupported for now;
    # see https://github.com/pytorch/cpuinfo/pull/82 for updates
    # NOTE: arm-windows is unsupported
    if(VCPKG_TARGET_ARCHITECTURE STREQUAL "x86")
        set(CPUINFO_TARGET_PROCESSOR_param "-DCPUINFO_TARGET_PROCESSOR=i386")
    elseif(VCPKG_TARGET_ARCHITECTURE STREQUAL "x64")
        set(CPUINFO_TARGET_PROCESSOR_param "-DCPUINFO_TARGET_PROCESSOR=AMD64")
    elseif(VCPKG_TARGET_ARCHITECTURE STREQUAL "arm")
        set(CPUINFO_TARGET_PROCESSOR_param "-DCPUINFO_TARGET_PROCESSOR=ARM")
    elseif(VCPKG_TARGET_ARCHITECTURE STREQUAL "arm64")
        set(CPUINFO_TARGET_PROCESSOR_param "-DCPUINFO_TARGET_PROCESSOR=ARM64")
    endif()
endif()

If the target is windows, CPUINFO_TARGET_PROCESSOR_param will be passed as an option to CMakeLists.txt of source by vcpkg_cmake_configure(), this option sets different values for CPUINFO_TARGET_PROCESSOR under different architectures.

But CMakeLists.txt of source have following content:
SET(CPUINFO_TARGET_PROCESSOR "${CMAKE_SYSTEM_PROCESSOR}")
This causes the value of CPUINFO_TARGET_PROCESSOR always be ${CMAKE_SYSTEM_PROCESSOR} even if the target is window.

If cpuinfo install with x86-windows, the value of ${CMAKE_SYSTEM_PROCESSOR} will be x86, this leads to a false result in the following judgment in CMakeLists.txt of source:

  IF(CPUINFO_TARGET_PROCESSOR MATCHES "^(i[3-6]86|AMD64|x86_64)$")
    ADD_EXECUTABLE(cpuid-dump tools/cpuid-dump.c)
    CPUINFO_TARGET_ENABLE_C99(cpuid-dump)
    CPUINFO_TARGET_RUNTIME_LIBRARY(cpuid-dump)
    TARGET_INCLUDE_DIRECTORIES(cpuid-dump BEFORE PRIVATE src)
    TARGET_INCLUDE_DIRECTORIES(cpuid-dump BEFORE PRIVATE include)
    INSTALL(TARGETS cpuid-dump RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
  ENDIF()

This is also the reason why cpuid-dump is not generated under x86-windows.
To solve this problem, I originally planned two scenarios:

1. Modify the part of the copy tool in the portfile.cmake so that it does not copy cpuid-dump under x86.
2. Modify the value of CPUINFO_TARGET_PROCESSOR to i386 when triplet is x86-windows, and add judgment to make CPUINFO_TARGET_PROCESSOR use the value passed by vcpkg_cmake_configure instead of ${CMAKE_SYSTEM_PROCESSOR}.

Because there is no documentation that cpuid-dump is not available under x86, I used scheme 2.

[BillyONeal]

@myd7349 @luncliff Do you have any comments on this patch and/or how we should let the upstream owners know?

[BillyONeal]

@LilyWangLL My point about upstream needing to be involved stands. However, I did my own digging here and am proposing a competing resolution here, which upstream has already OK'd: #25258

[Cheney-W]

Dup to #25258