Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always check for x86-ish with the same regex. #93

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Always check for x86-ish with the same regex. #93

merged 1 commit into from
Jul 5, 2022

Conversation

BillyONeal
Copy link
Contributor

On line 68, and in most places, "intel-like" is checked with i[3-6]86|AMD64|x86(_64)?, but in these 3 places the (_x64)? was missing.

First reported as microsoft/vcpkg#24713

On line 68, and in most places, "intel-like" is checked with `i[3-6]86|AMD64|x86(_64)?`, but in these 3 places the (_x64)? was missing.

First reported as microsoft/vcpkg#24713
Copy link
Contributor

@Maratyszcza Maratyszcza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Jun 15, 2022
BillyONeal added a commit to microsoft/vcpkg that referenced this pull request Jun 16, 2022
@malfet malfet merged commit 44d0af8 into pytorch:master Jul 5, 2022
@BillyONeal BillyONeal deleted the consistent-intel-ish branch July 5, 2022 17:24
megengine-bot pushed a commit to MegEngine/cpuinfo that referenced this pull request Sep 5, 2022
On line 68, and in most places, "intel-like" is checked with `i[3-6]86|AMD64|x86(_64)?`, but in these 3 places the (_x64)? was missing.

First reported as microsoft/vcpkg#24713

GitOrigin-RevId: 44d0af8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants