-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wxwidgets] Remove debug asserts from Release build. #25240
[wxwidgets] Remove debug asserts from Release build. #25240
Conversation
998987f
to
78cf6cf
Compare
78cf6cf
to
b67b3ec
Compare
b67b3ec
to
d0177f8
Compare
Patch to wxCharts also pushed to mainstream: wxIshiko/wxCharts#201 |
wxIshiko/wxCharts#201 PR is merged on upstream. Looks like there is no 'releases' on that repo and current vcpkg port also refers to just some particular commit. |
Yes, that would be great :) |
Currently when building wxWidgets in Release mode, the debug asserts are enabled. This fixes this issue by providing a necessary define to disable them. Ref: https://docs.wxwidgets.org/3.1.6/group__group__funcmacro__debug.html [wxCharts, vcpkg-ci-wxwidgets] Update ports to include fix for wxWidgets release build with debug asserts off when building a dynamic/shared library. Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
d0177f8
to
2ccf65a
Compare
@vicroms, done. Please review |
* Revert "[wxwidgets] Remove debug asserts from Release build. (#25240)" This reverts commit 6e16931. * Update to 3.1.7 * Update installation layout * Upstream CMake export is not ready for use * Update versions * Remove obsolete patch * Use msvc layout for mingw on windows * Add debug-support feature * Update versions * Fix condition * Update versions * Restore symlink patch * Update versions * Remove trace option from test port * Enable testing without feature debug-support * Fixup defaults for using without debug support * Expect wxrc-3.1 for mingw cross builds ("unix" layout) * Update versions
Currently when building wxWidgets in Release mode, the debug asserts are enabled.
This fixes this issue by providing a necessary define to disable them.
Ref: https://docs.wxwidgets.org/3.1.6/group__group__funcmacro__debug.html
Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com