Add possibility to remove debug asserts from the release build #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
|
I wasn't familiar with this wxDEBUG_LEVEL macro but looking at the documentation it impacts wxASSERT, wxFAIL and wxCHECK, which are not used in wxCharts (but probably should be at some point). |
|
@xleclercq, this PR fixes an issue when wxWidgets library is built with wxDEBUG_LEVEL=0 (that means no debug asserts) but when wxCharts using it without providing this flag (and by default in |
|
Thanks for explaining. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com