Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grpc] Fix protobuf protoc executable variable #26199

Merged
merged 2 commits into from
Aug 9, 2022
Merged

[grpc] Fix protobuf protoc executable variable #26199

merged 2 commits into from
Aug 9, 2022

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Aug 5, 2022 •
edited
Loading

The variable to specify the protoc executable was wrong.

  • What does your PR fix?

    N/A

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Yes

  • Does your PR follow the maintainer guide?

    I think so.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

github-actions[bot]
github-actions bot previously approved these changes Aug 5, 2022
View reviewed changes
@Cheney-W Cheney-W added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Aug 8, 2022
BillyONeal
BillyONeal requested changes Aug 8, 2022
View reviewed changes
ports/grpc/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

(To clarify, I marked 'request changes' so this shows up for you to respond, I don't object to the changes here, I just want to understand better before pushing the merge button)

@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 8, 2022
@ekilmer ekilmer changed the title [grpc] Fix cross compile [grpc] Fix protobuf protoc executable variable Aug 9, 2022
@ekilmer ekilmer mentioned this pull request Aug 9, 2022
Merged
@Cheney-W Cheney-W added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Aug 9, 2022
@BillyONeal BillyONeal merged commit a746679 into microsoft:master Aug 9, 2022
@BillyONeal
Copy link
Member

Thanks for the fix!

@ekilmer ekilmer deleted the fix-grpc-crosscompile branch August 9, 2022 20:48
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal requested changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekilmer @BillyONeal @Cheney-W