[vcpkg] Fix cross compiling macOS #26240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the pattern in the Windows toolchain with respect to setting VCPKG_CMAKE_SYSTEM_VERSION and also how arm64 macOS can execute x86_64 through Rosetta.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
added
the
category:vcpkg-bug
JackBoosY
approved these changes
Aug 9, 2022
|
Looks like the mac runner died while building LLVM https://dev.azure.com/vcpkg/public/_build/results?buildId=76307&view=logs&j=7b75bd19-17d3-53d4-00fd-23f1a49a8ba4&t=a23dba4e-3a62-59dc-a73c-a7222676d7a4&l=1001 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks a bunch! |
diegovelaz
added a commit
to diegovelaz/vcpkg
that referenced
this pull request
Aug 10, 2022
Format and add version. Update CI baseline. Update port version. [vcpkg] Fix cross compiling macOS (microsoft#26240) This follows the pattern in the Windows toolchain with respect to setting VCPKG_CMAKE_SYSTEM_VERSION and also how arm64 macOS can execute x86_64 through Rosetta. [buck-yeh-bux] fix clang-cl builds (microsoft#26248) * [buck-yeh-bux] fix clang-cl * v db [cppcms] Fix narrowing for clang-cl builds (microsoft#26251) * [cppcms] fix narrowing error with clang-cl * v db [crc32c] Clang-cl fix (microsoft#26253) * [crc32c] fix clang-cl builds. * v db [json-c] clang-cl fix. (microsoft#26254) * [json-c] fix clang-cl builds * v db [cpr] disable werror (microsoft#26252) * [cpr] disable werror * v db [sqlcipher] update to 4.5.2 (microsoft#26262) * [sqlcipher] update to 4.5.2 * requested changes * portfile.cmake - quote paths [osgearth] Fix naming of target and exported variables (microsoft#26258) * [osgearth] Fix target name and match exported variables * Fix version SHA Add port version to baseline. Add x64-linux build expected to fail. Add port 0 version. Update version database Specify supported CI so it only build dynamic. Update SHA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the pattern in the Windows toolchain with respect to
setting VCPKG_CMAKE_SYSTEM_VERSION and also how arm64 macOS can execute
x86_64 through Rosetta.
See here for more discussion/context on the pattern used in the Windows toolchain: #24100
Describe the pull request
What does your PR fix?
This PR was made after a discussion here: [grpc] Fix protobuf protoc executable variable #26199 (comment) when trying to fix cross-compilation from Intel x86_64 macOS to arm64 macOS.
Which triplets are supported/not supported? Have you updated the CI baseline?
Yes
Does your PR follow the maintainer guide?
I think so
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?N/A