[cpr] disable werror #26252
Merged
[cpr] disable werror #26252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
LilyWangLL
added
the
category:port-feature
LilyWangLL
reviewed
Aug 10, 2022
| endif() | ||
|
|
||
| -if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC") | ||
| +if (1) |
There was a problem hiding this comment.
If here set if (1), the other following options except Werror will be disable too, will this affect the installation?
There was a problem hiding this comment.
This is intentionally. Build scripts should never set flags such as -werror. since newer/different compilers might throw warnings upstream didn't test. So yes this is completely intentionally.
|
Thanks! |
diegovelaz
added a commit
to diegovelaz/vcpkg
that referenced
this pull request
Aug 10, 2022
Format and add version. Update CI baseline. Update port version. [vcpkg] Fix cross compiling macOS (microsoft#26240) This follows the pattern in the Windows toolchain with respect to setting VCPKG_CMAKE_SYSTEM_VERSION and also how arm64 macOS can execute x86_64 through Rosetta. [buck-yeh-bux] fix clang-cl builds (microsoft#26248) * [buck-yeh-bux] fix clang-cl * v db [cppcms] Fix narrowing for clang-cl builds (microsoft#26251) * [cppcms] fix narrowing error with clang-cl * v db [crc32c] Clang-cl fix (microsoft#26253) * [crc32c] fix clang-cl builds. * v db [json-c] clang-cl fix. (microsoft#26254) * [json-c] fix clang-cl builds * v db [cpr] disable werror (microsoft#26252) * [cpr] disable werror * v db [sqlcipher] update to 4.5.2 (microsoft#26262) * [sqlcipher] update to 4.5.2 * requested changes * portfile.cmake - quote paths [osgearth] Fix naming of target and exported variables (microsoft#26258) * [osgearth] Fix target name and match exported variables * Fix version SHA Add port version to baseline. Add x64-linux build expected to fail. Add port 0 version. Update version database Specify supported CI so it only build dynamic. Update SHA.
LilyWangLL
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.