Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gts] Enables osx and android, fixes, cleanup. #34673

Merged
merged 8 commits into from
Oct 27, 2023
Merged

[gts] Enables osx and android, fixes, cleanup. #34673

merged 8 commits into from
Oct 27, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 23, 2023

WIP.
Blocking gz-common5.

@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Oct 24, 2023
dg0yt
dg0yt commented Oct 24, 2023
View reviewed changes
ports/gts/portfile.cmake
if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
set(patches fix-dllexport.patch)
elseif(VCPKG_TARGET_IS_WINDOWS)
set(patches fix-dllexport_2.patch fix_missing_extern.patch)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR the dll exports are handled by upstream's def file now.

scripts/ci.baseline.txt
Comment on lines 465 to +466
ignition-common1:x64-linux=fail
ignition-common1:x64-osx=fail
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osx didn't build before this PR, and now suffers from the same problem as linux.
So it is not a regression, and fixing it is out of scope for this PR. (With gz-common5, there is a working successor.)

@dg0yt dg0yt marked this pull request as ready for review October 24, 2023 05:02
@dg0yt dg0yt changed the title [gts] Enables osx [gts] Enables osx and android, fixes, cleanup. Oct 24, 2023
@jimwang118
Copy link
Contributor 

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Oct 27, 2023
@data-queue data-queue merged commit 79be4be into microsoft:master Oct 27, 2023
15 checks passed
@dg0yt dg0yt deleted the patch-1 branch October 27, 2023 06:01
@dg0yt dg0yt mentioned this pull request Oct 29, 2023
Closed
dg0yt referenced this pull request Jul 5, 2024
@ras0219-msft
[gts] Move to official upstream sources (#25034)
053c82f 
* [gts] Move to official upstream sources

* [gts] Rename src->SOURCE_PATH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @jimwang118 @data-queue