Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ceres] update to 2.2.0 #35021

Closed
wants to merge 6 commits into from
Closed

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Nov 10, 2023

Fixes #34483

According to ceres-solver/ceres-solver@2335b5b, remove feature cxsparse.
According to ceres-solver/ceres-solver@0c88301, add dependency metis for feature eigensparse.
Modify 0003_fix_exported_ceres_config.patch to add the required dependencies.
Modify find-package-required.patch to use the ports provided by vcpkg.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Nov 10, 2023
@Cheney-W
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make good use of find_package(... NAMES ...) and add_library(... ALIAS ...) to trim the patch size.

ports/ceres/find-package-required.patch Outdated Show resolved Hide resolved
ports/ceres/find-package-required.patch Outdated Show resolved Hide resolved
ports/ceres/find-package-required.patch Outdated Show resolved Hide resolved
ports/ceres/find-package-required.patch Outdated Show resolved Hide resolved
ports/ceres/find-package-required.patch Outdated Show resolved Hide resolved
ports/ceres/find-package-required.patch Outdated Show resolved Hide resolved
ports/ceres/find-package-required.patch Outdated Show resolved Hide resolved
ports/ceres/find-package-required.patch Show resolved Hide resolved
ports/ceres/find-package-required.patch Outdated Show resolved Hide resolved
ports/ceres/find-package-required.patch Outdated Show resolved Hide resolved
@patrikhuber
Copy link
Contributor

patrikhuber commented Dec 12, 2023

According to ceres-solver/ceres-solver@0c88301, add dependency metis for feature eigensparse.

If I understood you correctly, you want to add a dependency on metis whenever the feature ceres[eigensparse] is requested? As far as I understand ceres-solver/ceres-solver@0c88301, metis is not a dependency of eigensparse, it's an optional extra (depending on CERES_NO_EIGEN_METIS). If that is the case, then please don't pull in metis as a dependency whenever someone requests ceres[eigensparse] - only pull in metis as a dependency if someone actually requests ceres[metis]. There is a big appeal in having a minimal (almost-)no dependency ceres when one does vcpkg install ceres[eigensparse].

@jbuonagurio jbuonagurio mentioned this pull request Feb 23, 2024
7 tasks
@hesmar
Copy link
Contributor

hesmar commented Mar 1, 2024

What is the status of this PR? Is anyone still working on it? I would like to create another patch for Ceres which will be based on 2.2.0. So it would be nice to have this in master.

@patrikhuber
Copy link
Contributor

It would be really great to have Ceres 2.2.0 available in vcpkg, it's been out for quite a few months now.

@hesmar
Copy link
Contributor

hesmar commented May 17, 2024

@Cheney-W Are you still working on it?

@moolawooda
Copy link

So, is there any progress at the moment?

@saulthu
Copy link
Contributor

saulthu commented Aug 21, 2024

Bump🤜

@Cheney-W Cheney-W closed this Aug 21, 2024
@saulthu
Copy link
Contributor

saulthu commented Aug 21, 2024

@Cheney-W Any update on why this was closed? (Thanks for the efforts BTW!)

@valgur
Copy link
Contributor

valgur commented Aug 21, 2024

Just FYI, I intend to re-open a v2.2.0 PR after #39297 is merged.

@Cheney-W
Copy link
Contributor Author

I encountered some compilation issues during the update, and I'm not sure how to resolve them yet. To avoid blocking others from updating this port, I've decided to close this PR for now. I will carefully investigate the errors on my local machine, and once I resolve them, if no one else has updated this port, I will reopen my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ceres] update to 2.2.0
8 participants