-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ceres] update to 2.2.0 #35021
[ceres] update to 2.2.0 #35021
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make good use of find_package(... NAMES ...)
and add_library(... ALIAS ...)
to trim the patch size.
If I understood you correctly, you want to add a dependency on metis whenever the feature ceres[eigensparse] is requested? As far as I understand ceres-solver/ceres-solver@0c88301, metis is not a dependency of eigensparse, it's an optional extra (depending on |
What is the status of this PR? Is anyone still working on it? I would like to create another patch for Ceres which will be based on 2.2.0. So it would be nice to have this in master. |
It would be really great to have Ceres 2.2.0 available in vcpkg, it's been out for quite a few months now. |
@Cheney-W Are you still working on it? |
So, is there any progress at the moment? |
Bump🤜 |
@Cheney-W Any update on why this was closed? (Thanks for the efforts BTW!) |
Just FYI, I intend to re-open a v2.2.0 PR after #39297 is merged. |
I encountered some compilation issues during the update, and I'm not sure how to resolve them yet. To avoid blocking others from updating this port, I've decided to close this PR for now. I will carefully investigate the errors on my local machine, and once I resolve them, if no one else has updated this port, I will reopen my PR. |
Fixes #34483
According to ceres-solver/ceres-solver@2335b5b, remove feature
cxsparse
.According to ceres-solver/ceres-solver@0c88301, add dependency
metis
for featureeigensparse
.Modify
0003_fix_exported_ceres_config.patch
to add the required dependencies.Modify
find-package-required.patch
to use the ports provided by vcpkg.The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.