[gflags] Cleanup, fix usage #35188
Merged
[gflags] Cleanup, fix usage #35188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankXie05
added
the
category:port-bug
FrankXie05
approved these changes
Nov 20, 2023
data-queue
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug postfix is hardcoded to
_debug.Restores pristine plain
find_package(CONFIG)which creates non-namespaced targets, and requires an input variable for namespaced targets.To not break users which adopted the vcpkg pattern, the namespaced targets are also generated when the input variable is not set.
The usage recommends the input variable now.
Triggered by the surprising trouble in #35021 (comment).
NOTE: Most vcpkg patches replacing
gflagswithgflags::gflagsare obsolete and only motivated by the port's usage quirks. These patches should be removed when ports are updated.