Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing JsonRpc method to expose only members of a given interface from a given RPC target object #517

Closed
TonyValenti opened this issue Aug 10, 2020 · 0 comments · Fixed by #519
Closed

Missing JsonRpc method to expose only members of a given interface from a given RPC target object #517

TonyValenti opened this issue Aug 10, 2020 · 0 comments · Fixed by #519
Assignees
@AArnott
Labels
enhancement
Milestone
v2.6

Comments

@TonyValenti
Copy link

Please provide an overload of attach that allows me to:

  1. Specify the object being attached to
  2. Provide the type of the object being attached to.

The reason I want to specify the type is as follows:
Currently I have an Object that I want to expose. I only want to expose certain members of the object and those members are defined in an interface. The interface is fully compatible with Json RPC. The implementation of my interface is not because it contains incompatible events.

I believe that if I could attach and specify a type, I could constrain the generated proxy to the members of the interface.
@AArnott AArnott changed the title New attach overload Missing JsonRpc method to expose only members of a given interface from a given RPC target object Aug 10, 2020
@AArnott AArnott self-assigned this Aug 11, 2020
@AArnott AArnott added this to the v2.6 milestone Aug 11, 2020
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Aug 11, 2020
@AArnott
Add JsonRpc.AddLocalRpcTarget<T> method
516c9ea 
This method restricts RPC surface area to only members defined on the type T instead of all (public) members on the target object.

Closes microsoft#517
@AArnott AArnott mentioned this issue Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
enhancement
Projects
None yet
Milestone
v2.6
Development

Successfully merging a pull request may close this issue.

Add JsonRpc.AddLocalRpcTarget<T> method AArnott/vs-streamjsonrpc
2 participants
@AArnott @TonyValenti