Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonRpc.AddLocalRpcTarget<T> method #519

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Aug 11, 2020

This method restricts RPC surface area to only members defined on the type T instead of all (public) members on the target object.

Closes #517

This method restricts RPC surface area to only members defined on the type T instead of all (public) members on the target object.

Closes microsoft#517
@AArnott AArnott added this to the v2.6 milestone Aug 11, 2020
@AArnott AArnott requested review from javierdlg and milopezc August 11, 2020 21:51
@AArnott AArnott self-assigned this Aug 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #519 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   89.20%   89.21%   +0.01%     
==========================================
  Files          51       51              
  Lines        4067     4071       +4     
==========================================
+ Hits         3628     3632       +4     
  Misses        439      439              
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonRpc.cs 92.79% <100.00%> (+0.03%) ⬆️
...pc/Reflection/MessageFormatterDuplexPipeTracker.cs 94.25% <0.00%> (-1.15%) ⬇️
src/StreamJsonRpc/MessageHandlerBase.cs 98.78% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc4f1e4...516c9ea. Read the comment docs.

@AArnott AArnott merged commit 15a7fa1 into microsoft:master Aug 11, 2020
@AArnott AArnott deleted the fix517 branch August 11, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing JsonRpc method to expose only members of a given interface from a given RPC target object
3 participants