Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonRpc.TransmitAsync logs OperationCanceledException #550

Closed
tmat opened this issue Sep 16, 2020 · 0 comments · Fixed by #552
Closed

JsonRpc.TransmitAsync logs OperationCanceledException #550

tmat opened this issue Sep 16, 2020 · 0 comments · Fixed by #552
Assignees
@AArnott
Labels
bug
Milestone
v2.6

Comments

@tmat
Copy link
Member

tmat commented Sep 16, 2020

This line shouldn't get executed when the exception is OperationCanceledException
@AArnott AArnott self-assigned this Sep 16, 2020
@AArnott AArnott added the bug label Sep 16, 2020
@AArnott AArnott added this to the v2.6 milestone Sep 17, 2020
@AArnott AArnott mentioned this issue Sep 17, 2020
Merged
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Sep 17, 2020
@AArnott
Do not log transmission cancellation as an error
0cbae16 
Fixes microsoft#550
@AArnott AArnott closed this as completed Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
bug
Projects
None yet
Milestone
v2.6
Development

Successfully merging a pull request may close this issue.

Do not log transmission cancellation as an error AArnott/vs-streamjsonrpc
2 participants
@AArnott @tmat