Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log transmission cancellation as an error #552

Merged
1 commit merged into from
Sep 18, 2020

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Sep 17, 2020

Fixes #550

@AArnott AArnott requested a review from tmat September 17, 2020 16:18
@AArnott AArnott added this to the v2.6 milestone Sep 17, 2020
@AArnott AArnott self-assigned this Sep 17, 2020
@AArnott AArnott requested a review from javierdlg September 17, 2020 16:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2020

Codecov Report

Merging #552 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   89.92%   89.88%   -0.05%     
==========================================
  Files          54       54              
  Lines        4438     4440       +2     
==========================================
  Hits         3991     3991              
- Misses        447      449       +2     
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonRpc.cs 93.04% <100.00%> (-0.32%) ⬇️
...pc/Reflection/MessageFormatterDuplexPipeTracker.cs 95.40% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e873ba...0cbae16. Read the comment docs.

@ghost ghost merged commit 9305996 into microsoft:master Sep 18, 2020
@AArnott AArnott deleted the fix550 branch September 18, 2020 17:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonRpc.TransmitAsync logs OperationCanceledException
4 participants