Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/vs/16.8-preview.1 to master #507

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Jul 23, 2020

No description provided.

AArnott and others added 2 commits July 22, 2020 20:20
We should not use the short form jump instruction when the instructions between the jump source and target may exceed 127... (IL instructions? bytes?). Anyway, as a rule then, I've switched to long form whenever the jump crosses an IL generating loop, such that we can't be confident that the number of instructions will be small.
Fixed proxy generation for methods with many parameters
@AArnott AArnott added this to the v2.6 milestone Jul 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #507 into master will decrease coverage by 1.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   90.36%   89.30%   -1.06%     
==========================================
  Files          50       51       +1     
  Lines        3892     4068     +176     
==========================================
+ Hits         3517     3633     +116     
- Misses        375      435      +60     
Impacted Files Coverage Δ
src/StreamJsonRpc/ProxyGeneration.cs 99.73% <100.00%> (ø)
src/StreamJsonRpc/JsonMessageFormatter.cs 90.72% <0.00%> (-5.01%) ⬇️
src/StreamJsonRpc/LengthHeaderMessageHandler.cs 94.87% <0.00%> (-2.36%) ⬇️
src/StreamJsonRpc/MessagePackFormatter.cs 91.38% <0.00%> (-1.48%) ⬇️
src/StreamJsonRpc/HeaderDelimitedMessageHandler.cs 85.31% <0.00%> (-0.33%) ⬇️
src/StreamJsonRpc/JsonRpcEventSource.cs 6.66% <0.00%> (-0.32%) ⬇️
src/StreamJsonRpc/Protocol/JsonRpcError.cs 76.19% <0.00%> (ø)
...sonRpc/Reflection/ExceptionSerializationHelpers.cs 47.72% <0.00%> (ø)
src/StreamJsonRpc/JsonRpc.cs 93.07% <0.00%> (+0.65%) ⬆️
...pc/Reflection/MessageFormatterDuplexPipeTracker.cs 95.40% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59fa62...f4be865. Read the comment docs.

@AArnott AArnott merged commit d490e9d into master Jul 23, 2020
@AArnott AArnott deleted the release/vs/16.8-preview.1 branch July 23, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants