Refactor quick pick filters #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweininger
commented
Jul 14, 2022
| export class QuickPickAppResourceStep<TModel extends ResourceModelBase> extends AzureWizardPromptStep<QuickPickAppResourceWizardContext<TModel>> { | ||
| public constructor( | ||
| private readonly resourceProviderManager: ApplicationResourceProviderManager, | ||
| private readonly branchDataProviderManager: BranchDataProviderManager, | ||
| private readonly options: PickAppResourceOptions | ||
| private readonly filter?: Filter<AppResource> | Filter<AppResource>[], |
There was a problem hiding this comment.
I promoted filter from inside options to a top level parameter because in most cases we will want to filter the app resources.
|
|
||
| constructor(private readonly options: AppResourceFilterOptions) { } | ||
|
|
||
| public matches(resource: AppResource): boolean { |
There was a problem hiding this comment.
Once microsoft/vscode-azuretools#1191 is merged, we can change the body of this method to
return resource.azureResourceType === this.azureResourceTypewithout having to make changes elsewhere.
This was referenced Jul 14, 2022
…ckpick' into alex/resource-api-qp-filters
…lex/resource-api-qp-filters
…lex/resource-api-qp-filters
alexweininger
force-pushed
the
alex/resource-api-qp-filters
branch
from
2157818 to
6e9efec
Compare
…ckpick' into alex/resource-api-qp-filters
…ckpick' into alex/resource-api-qp-filters
|
Closing in favor of microsoft/vscode-azuretools#1229 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think my implementation reduces the likelihood of breaking changes by making the interfaces and parameters used to control quick pick filtering more abstract.
Note: the app resource filter will be able to easily utilize microsoft/vscode-azuretools#1191 once we make those changes.