-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the ultimate quick pick experience #1229
Conversation
Tree Item Pick scenariosThese scenarios cover all of the current uses of the Tree Item Picker API (TIP). More common scenarios are sorted to the top. A. Pick an Azure resource of a specific type (optional create) B. Pick a child of an Azure resource (optional create) C. Pick an Azure resource or Workspace resource D. Pick a child of an Azure resource or Workspace resource E. Pick an Azure resource (of ANY type) or a child of this resource |
So far in my initial testing it works well. I had to make a few small changes but the concept is proven for sure. I want to go deeper and make sure we can cover all scenarios I outlined so I will report back next week with those results. |
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Changed the base to the |
utils/src/treev2/quickPickWizard/quickPickAzureResource/tempTypes.ts
Outdated
Show resolved
Hide resolved
Just a note: we keep calling this the quick pick experience, but I think "pick tree item wizard" or "tree item picker wizard" is a better name. 😄 |
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
utils/src/treev2/quickPickWizard/quickPickAzureResource/QuickPickAzureResourceGroupStep.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've resolved any open comments that I had. Anyway, looks good to me 👍
No description provided.