Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the ultimate quick pick experience #1229

Merged
merged 55 commits into from
Dec 7, 2022
Merged

Conversation

bwateratmsft
Copy link
Contributor

No description provided.

@alexweininger
Copy link
Member

Tree Item Pick scenarios

These scenarios cover all of the current uses of the Tree Item Picker API (TIP). More common scenarios are sorted to the top.

A. Pick an Azure resource of a specific type (optional create)
Example: "Azure Functions: Deploy to Function App" command must pick a deploy target

B. Pick a child of an Azure resource (optional create)
Example: "Azure Functions: Deploy to Slot" command must pick a slot of a Function App. If one doesn't exist, user should be presented with the option to create one.

C. Pick an Azure resource or Workspace resource
Example: "Azure Storage: Create Queue" command must pick a Storage account in Azure, or an attached (emulated) one

D. Pick a child of an Azure resource or Workspace resource
Example: "Azure Functions: Execute Function Now" command must pick a Function running in Azure, or a Function from a Functions Project in the workspace being run locally

E. Pick an Azure resource (of ANY type) or a child of this resource
Example: "Azure: View in Portal" command must pick any Azure resource or child resource that can be opened in the portal.

@alexweininger
Copy link
Member

So far in my initial testing it works well. I had to make a few small changes but the concept is proven for sure. I want to go deeper and make sure we can cover all scenarios I outlined so I will report back next week with those results.

alexweininger and others added 2 commits September 2, 2022 14:20
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
@bwateratmsft bwateratmsft changed the base branch from main to api-v2 September 6, 2022 13:38
@bwateratmsft
Copy link
Contributor Author

Changed the base to the api-v2 branch.

@alexweininger
Copy link
Member

Just a note: we keep calling this the quick pick experience, but I think "pick tree item wizard" or "tree item picker wizard" is a better name. 😄

alexweininger and others added 3 commits September 7, 2022 13:01
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
alexweininger and others added 3 commits September 15, 2022 09:25
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
alexweininger and others added 2 commits September 23, 2022 11:26
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
utils/hostapi.v2.d.ts Outdated Show resolved Hide resolved
utils/index.d.ts Outdated Show resolved Hide resolved
utils/index.d.ts Outdated Show resolved Hide resolved
utils/src/tree/AzExtParentTreeItem.ts Outdated Show resolved Hide resolved
utils/src/treev2/quickPickWizard/GenericQuickPickStep.ts Outdated Show resolved Hide resolved
utils/src/treev2/quickPickWizard/QuickPickWizardContext.ts Outdated Show resolved Hide resolved
utils/src/utils/apiUtils.ts Outdated Show resolved Hide resolved
Base automatically changed from api-v2 to main December 6, 2022 21:20
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've resolved any open comments that I had. Anyway, looks good to me 👍

@alexweininger alexweininger merged commit a980b81 into main Dec 7, 2022
@alexweininger alexweininger deleted the bmw/quickPick_v8.30 branch December 7, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants