Remove reliance on quickPickOptions, use TreeItems directly
#1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils/src/treev2/quickPickWizard/experiences/appResourceExperience.ts
Outdated
Show resolved
Hide resolved
utils/src/treev2/quickPickWizard/experiences/compatibilityPickResourceExperience.ts
Outdated
Show resolved
Hide resolved
utils/src/treev2/quickPickWizard/quickPickAzureResource/QuickPickAzureSubscriptionStep.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
bwateratmsft
approved these changes
Sep 22, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of grabbing
contextValues: string[]andisLeaf: booleanfrom the elements (aka things returned byvscode.TreeDataProvider.getChildren), callvscode.TreeDataProvider.getTreeItemto get avscode.TreeItemback.We can derive the info we need from the
TreeItem.isLeaf->collapsibleState,contextValues->contextValue.I ran into issues because
isLeafandcontextValuesweren't the only things we attached to the elements that we need in the quick pick wizard. For compatibility with the oldcreateChildImpl, I was attaching info related to create.I've moved that compatibility logic into
CompatibilityRecursiveQuickPickStep.See how these changes impact Resource Groups: microsoft/vscode-azureresourcegroups#392