Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility steps #1235

Merged
merged 34 commits into from
Sep 15, 2022
Merged

Add compatibility steps #1235

merged 34 commits into from
Sep 15, 2022

Conversation

alexweininger
Copy link
Member

@alexweininger alexweininger commented Sep 14, 2022 •
edited
Loading

  • CompatibilityRecursiveQuickPickStep - provides compatibility with the AzExtParentTreeItem.pickTreeItemImpl method.
  • CompatibilityContextValueQuickPickStep - provides compatibility with AzExtParentTreeItem.createChildImpl and related properties for showing a "+ Create..." pick.
  • Added _isAzExtTreeItem: boolean property to AzExtTreeItem
    • clients will need to update to the latest utils to pick up this change
  • Removed compatibility logic from the existing steps, since the dedicated compatibility steps should be used whenever compatibility with the old AzExtTreeItems is needed.

Associated Resource Groups branch: https://github.com/microsoft/vscode-azureresourcegroups/tree/alex/compat-shim-with-pick-app-resource

Azure Functions branch: https://github.com/microsoft/vscode-azurefunctions/tree/alex/api-v2-compat

@alexweininger alexweininger requested a review from a team as a code owner September 14, 2022 17:17
bwateratmsft
bwateratmsft reviewed Sep 14, 2022
View reviewed changes
utils/src/treev2/quickPickWizard/compatibility/CompatibilityContextValueQuickPickStep.ts Outdated Show resolved Hide resolved
utils/index.d.ts Outdated Show resolved Hide resolved
utils/index.d.ts Outdated Show resolved Hide resolved
utils/index.d.ts Outdated Show resolved Hide resolved
alexweininger and others added 4 commits September 14, 2022 12:28
This was referenced Sep 15, 2022
Merged
Merged
Closed
@alexweininger alexweininger merged commit 09ec22a into bmw/quickPick_v8.30 Sep 15, 2022
@alexweininger alexweininger deleted the alex/tip-changes3 branch September 15, 2022 16:25
@alexweininger alexweininger mentioned this pull request Sep 21, 2022
Closed
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexweininger @bwateratmsft