-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CompatibleBranchDataItem
#381
Merged
alexweininger
merged 24 commits into
bmw/philliphoff-resource-api-compatshim
from
alex/compat-shim-changes-1
Sep 23, 2022
Merged
Add CompatibleBranchDataItem
#381
alexweininger
merged 24 commits into
bmw/philliphoff-resource-api-compatshim
from
alex/compat-shim-changes-1
Sep 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/api/v2/compatibility/CompatibleAzureResourceGroupsExtensionApi.ts
Outdated
Show resolved
Hide resolved
This reverts commit ad11348.
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
What's the status on getting this merged? |
bwateratmsft
approved these changes
Sep 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1 of 3 - should merge/review this PR before the others
Depends on utils version from microsoft/vscode-azuretools#1235
Changes provide compatibility with V1
registerAppResourceResolver
method by registering aCompatibleBranchDataProvider
wrapped around the given resolver.This means that with minimal changes (view changes required for Functions), "trees" (resolvers) client extensions provide for V1, work with V2.