Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompatibleBranchDataItem #381

Merged

Conversation

alexweininger
Copy link
Member

@alexweininger alexweininger commented Sep 15, 2022

PR 1 of 3 - should merge/review this PR before the others

Depends on utils version from microsoft/vscode-azuretools#1235

Changes provide compatibility with V1 registerAppResourceResolver method by registering a CompatibleBranchDataProvider wrapped around the given resolver.

This means that with minimal changes (view changes required for Functions), "trees" (resolvers) client extensions provide for V1, work with V2.

image

src/tree/v2/providers/BranchDataProviderManager.ts Outdated Show resolved Hide resolved
src/api/registerApplicationResourceResolver.ts Outdated Show resolved Hide resolved
src/api/v2/compatibility/CompatibleBranchDataProvider.ts Outdated Show resolved Hide resolved
src/api/registerApplicationResourceResolver.ts Outdated Show resolved Hide resolved
src/tree/v2/BranchDataItem.ts Outdated Show resolved Hide resolved
src/tree/v2/CompatibleBranchDataItem.ts Outdated Show resolved Hide resolved
src/tree/v2/providers/BuiltInApplicationResourceItem.ts Outdated Show resolved Hide resolved
alexweininger and others added 2 commits September 16, 2022 11:16
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
@alexweininger alexweininger mentioned this pull request Sep 21, 2022
66 tasks
@alexweininger
Copy link
Member Author

What's the status on getting this merged?

@alexweininger alexweininger merged commit a10244e into bmw/philliphoff-resource-api-compatshim Sep 23, 2022
@alexweininger alexweininger deleted the alex/compat-shim-changes-1 branch September 23, 2022 20:08
@microsoft microsoft locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants