-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start implementation of compat shim #358
Start implementation of compat shim #358
Conversation
We're currently storing branch data providers in a map using the Id passed during registration as the key. Currently, that Id wasn't used for anything, but now we are using that Id to lookup the BDP for a given application resource. BranchDataProviderManager.ts where we find a branch data provider for a given application resource Two things:
|
I think once we've determined the BDP, we should attach it to RG's model objects for the entire tree. @philliphoff may already be doing that. |
…ource-api-compatshim
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
…ource-api-compatshim
…ource-api-compatshim
src/api/v2/compatibility/application/CompatibleApplicationResourceTreeItem.ts
Outdated
Show resolved
Hide resolved
src/api/v2/compatibility/application/CompatibleApplicationResourceTreeItem.ts
Show resolved
Hide resolved
…urceTreeItem.ts Co-authored-by: Nathan <naturins@microsoft.com>
src/api/v2/compatibility/workspace/CompatibilityWorkspaceResourceProvider.ts
Outdated
Show resolved
Hide resolved
|
Making as a draft PR to gather feedback.