Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start implementation of compat shim #358

Merged
merged 87 commits into from
Dec 7, 2022

Conversation

bwateratmsft
Copy link
Contributor

Making as a draft PR to gather feedback.

Base automatically changed from philliphoff-resource-api to api-v2 September 7, 2022 15:16
@alexweininger
Copy link
Member

We're currently storing branch data providers in a map using the Id passed during registration as the key. Currently, that Id wasn't used for anything, but now we are using that Id to lookup the BDP for a given application resource.

BranchDataProviderManager.ts where we find a branch data provider for a given application resource

Two things:

  1. We should be mapping them by AzExtResourceType rather than type since type has some overlap
  2. We'll have to update the Ids we're passing to registerAppResourceResolver in the client extensions, since they are random (some pass in the extensionId, others pass in resource type). We'll update them to use AzExtResourceType.

@bwateratmsft
Copy link
Contributor Author

We're currently storing branch data providers in a map using the Id passed during registration as the key. Currently, that Id wasn't used for anything, but now we are using that Id to lookup the BDP for a given application resource.

BranchDataProviderManager.ts where we find a branch data provider for a given application resource

Two things:

  1. We should be mapping them by AzExtResourceType rather than type since type has some overlap
  2. We'll have to update the Ids we're passing to registerAppResourceResolver in the client extensions, since they are random (some pass in the extensionId, others pass in resource type). We'll update them to use AzExtResourceType.

I think once we've determined the BDP, we should attach it to RG's model objects for the entire tree. @philliphoff may already be doing that.

@alexweininger alexweininger mentioned this pull request Sep 21, 2022
66 tasks
alexweininger and others added 10 commits September 23, 2022 13:08
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
…urceTreeItem.ts

Co-authored-by: Nathan <naturins@microsoft.com>
src/api/registerApplicationResourceResolver.ts Outdated Show resolved Hide resolved
src/api/registerWorkspaceResourceProvider.ts Outdated Show resolved Hide resolved
src/api/registerWorkspaceResourceProvider.ts Outdated Show resolved Hide resolved
src/api/v2/v2AzureResourcesApi.ts Outdated Show resolved Hide resolved
src/tree/AppResourceTreeItem.ts Show resolved Hide resolved
src/tree/v2/ResourceBranchDataProviderManagerBase.ts Outdated Show resolved Hide resolved
src/tree/v2/BranchDataProviderItem.ts Show resolved Hide resolved
src/tree/v2/azure/GroupingItem.ts Show resolved Hide resolved
src/tree/v2/azure/GroupingItem.ts Outdated Show resolved Hide resolved
@alexweininger
Copy link
Member

I believe all comments have been resolved.

@bwateratmsft
Copy link
Contributor Author

bwateratmsft commented Dec 7, 2022

I believe all comments have been resolved.

:shipit:

@alexweininger alexweininger merged commit 659e881 into api-v2 Dec 7, 2022
@alexweininger alexweininger deleted the bmw/philliphoff-resource-api-compatshim branch December 7, 2022 20:20
@microsoft microsoft locked and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants