Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all ids with account and tenant ids #991

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Prefix all ids with account and tenant ids #991

merged 1 commit into from
Dec 19, 2024

Conversation

alexweininger
Copy link
Member

@alexweininger alexweininger commented Dec 19, 2024

Fixes #972

Add the /accounts/<accountId>/tenants/<tenantId> prefix to all items. This includes adding it to each item level in Resources: subscription items, grouping items, and resource items. Then I prefix all items provided by contributed branch data providers as well.

@alexweininger alexweininger requested a review from a team as a code owner December 19, 2024 22:28
@alexweininger alexweininger requested review from Copilot and removed request for a team December 19, 2024 22:30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/tree/BranchDataItemCache.ts: Evaluated as low risk
  • src/tree/BranchDataItemWrapper.ts: Evaluated as low risk
  • src/tree/ResourceTreeDataProviderBase.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/tree/azure/AzureResourceItem.ts:31

  • Ensure that the prefix is added only once to avoid duplicate prefixes. Consider checking if the prefix is already present before adding it.
readonly id = `${createAzureIdPrefix(this.resource.subscription)}${this.resource.id}`;
@alexweininger alexweininger merged commit 7b2ffa7 into main Dec 19, 2024
3 checks passed
@alexweininger alexweininger deleted the alex/ids branch December 19, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants