Update ui package to new azure sdk for js #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2020
nturinski
reviewed
Jul 27, 2020
nturinski
approved these changes
Jul 27, 2020
| } | ||
| } | ||
|
|
||
| public async sendRequest(options: RequestPrepareOptions | WebResourceLike): Promise<HttpOperationResponse> { |
There was a problem hiding this comment.
Is this to replace the requestUtils.sendRequest? I don't understand why it's in the createAzureClient file.
There was a problem hiding this comment.
It's a part of GenericServiceClient, which is returned in createGenericClient
There was a problem hiding this comment.
But anyways - yes this is related to replacing requestUtils. I figured createGenericClient was similar enough to createAzureClient that it could fit here. Only the function createGenericClient is actually exported, not GenericServiceClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure Account extension is currently restricted to VS Code Insiders, but I think there's enough change here that we can get started testing now. I used the resource groups and functions extensions as test subjects (PRs coming soon) and it all seems to be working.
For the UI package, here's the only difference noticeable to the user - if they don't have the latest account extension, we'll display a warning:
Fixes #510
Depends on #775