Update to new azure-sdk-for-js #2257
Conversation
| @@ -80,9 +79,13 @@ function installFuncCli() { | |||
| } | |||
|
|
|||
| async function gulp_installPythonExtension() { | |||
| return gulp_installVSCodeExtension('ms-python', 'python'); | |||
| return gulp_installVSCodeExtension('ms-python', 'python', true); | |||
There was a problem hiding this comment.
Why change this to use Insiders only?
There was a problem hiding this comment.
The Azure Account extension stuff is a part of VS Code 1.48 (see this comment), so we have to run tests on insiders until 1.48 goes stable
| // tslint:disable-next-line:no-string-literal no-unsafe-any | ||
| .filter(entry => entry['m:properties']['d:IsPrerelease']['_'] === 'false') | ||
| // tslint:disable-next-line:no-string-literal no-unsafe-any | ||
| private async parseLatestAzModuleVersion(response: HttpOperationResponse): Promise<string> { |
There was a problem hiding this comment.
I don't think this is async anymore.
| }); | ||
|
|
||
| // tslint:disable-next-line:no-string-literal no-unsafe-any | ||
| if (moduleInfo['feed'] && moduleInfo['feed']['entry'] && Array.isArray(moduleInfo['feed']['entry'])) { |
There was a problem hiding this comment.
How come you were able to get rid of this logic completely?
There was a problem hiding this comment.
The new sdk will automatically parse xml and return it in response.parsedBody, so I changed to use that instead of manually parsing with "xml2js" ourselves. When I went to test it, the parsed object was slightly different, not entirely sure why. The new sdk still uses "xml2js" under the covers, but maybe they pass in different options?
|
|
||
| [this._rawBindings, this._rawResources, this._rawTemplates] = <[object, object, object[]]>( | ||
| await Promise.all([bindingsRequest, resourcesRequest, templatesRequest].map(requestUtils.sendRequest)) | ||
| ).map(parseJson); | ||
| await Promise.all([release.bindings, resourcesUrl, release.functions].map(url => requestUtils.sendRequestWithTimeout({ method: 'GET', url }))) |
There was a problem hiding this comment.
I don't know if it's worth condensing all of this just to look cleaner. For instance, I don't think I'd realize release.functions is the url to retrieve templates.
There was a problem hiding this comment.
Didn't do it to look cleaner. Just did it because the new requestUtils only has one method (sendRequestWithTimeout) whereas the old requestUtils had two (getDefaultRequestWithTimeout and sendRequest)
| } catch (error) { | ||
| if (parseError(error).errorType === 'ETIMEDOUT') { | ||
| if (parseError(error).errorType === 'REQUEST_ABORTED_ERROR') { |
There was a problem hiding this comment.
Why did the error type change?
There was a problem hiding this comment.
This error type is defined by the sdk and the new sdk has different errors 🤷♂️ Something to watch out for in all extensions when moving to the new sdk
Depends on microsoft/vscode-azuretools#775
Depends on microsoft/vscode-azuretools#776
Depends on microsoft/vscode-azuretools#777
Depends on microsoft/vscode-azuretools#778