Update kudu package to new azure sdk for js #777
Conversation
| "author": "Microsoft Corporation", | ||
| "version": "0.1.9", | ||
| "description": "Client used to interact with Kudu.", | ||
| "tags": [ |
There was a problem hiding this comment.
Any reason to remove these tags?
There was a problem hiding this comment.
This change was related to the auto-generation, not intentional. In any case, the main goal of this package is for our own use, so tags don't really matter
| @@ -0,0 +1,37 @@ | |||
| import rollup from "rollup"; | |||
There was a problem hiding this comment.
Does this need a license at the top too?
There was a problem hiding this comment.
I'm not worried about it. This file was generated with autorest, and the main sdk repo doesn't seem to add it to their files either - for example: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/appservice/arm-appservice/rollup.config.js
| "moduleResolution": "node", | ||
| "strict": true, | ||
| "target": "es5", |
There was a problem hiding this comment.
Should the target have changed especially since the module is es6?
There was a problem hiding this comment.
This file was generated by autorest, so I'd rather just trust them to pick this stuff
This PR is actually way fewer files than it seems because almost all of it is auto-generated by autorest (including all the ts files, tsconfig.json, rollup.config.js, and even parts of package.json). The main files we will ever edit are "autorestconfig.json" and "swagger.json"
Related to #510