Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #1515

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Improve documentation #1515

merged 1 commit into from
Feb 7, 2018

Conversation

faheel
Copy link
Contributor

@faheel faheel commented Feb 2, 2018

  • Improve Markdown formatting
    • Use lists and headings at appropriate places (eg. to list configuration options/properties)
    • Increase heading levels that were too small
    • Remove extra indentation at a few places
  • Use consistent formatting rules for all Markdown files
    • Files and folders are in bold
    • Code and commands are in code spans/blocks and syntax highlighted
  • Fix typos
  • Fix broken links

Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements to our documentation!


#### How fallback works and how to control the behavior
### How fallback works and how to control the behavior?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that a question mark belongs here. No question is being asked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I'll fix it.

* [How do I get IntelliSense to work correctly?](#how-do-i-get-intellisense-to-work-correctly)
* [Why do I see red squiggles under Standard Library types?](#why-do-i-see-red-squiggles-under-standard-library-types)
* [How do I get the new IntelliSense to work with MinGW on Windows?](#how-do-i-get-the-new-intellisense-to-work-with-mingw-on-windows)
* [What is the difference between `"includePath"` and `"browse.path"` in **c_cpp_properties.json**?](#what-is-the-difference-between-includepath-and-browsepath-in-c-cpp-propertiesjson)
Copy link
Member

@bobbrow bobbrow Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link appears to be removed (link #4)


### Microsoft Open Source Code of Conduct
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.

This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact opencode@microsoft.com with any additional questions or comments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason why the mailto: link is removed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link seems to work without it? Maybe GitHub is smart about it and adds stuff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was redundant. A mailto link is automatically generated for an email address.

* improve Markdown formatting
* use consistent formatting rules for all Markdown files
* fix typos
* fix broken links
Copy link
Collaborator

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bunch of errors were fixed. And different tagging used. Seems good to me.

@sean-mcmanus
Copy link
Collaborator

@bobbrow Were you okay with accepting this pull request?

@bobbrow
Copy link
Member

bobbrow commented Feb 6, 2018

I'm confused. I didn't see any updates pushed to this PR and there is only one commit listed. When did it get updated?

Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@faheel
Copy link
Contributor Author

faheel commented Feb 7, 2018

I squashed the changes suggested in the review into the original PR commit.

@bobbrow bobbrow merged commit e6d8d1f into microsoft:master Feb 7, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants