Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support @container, prepare 6.2.10 #365

Merged
merged 3 commits into from
Oct 5, 2023
Merged

support @container, prepare 6.2.10 #365

merged 3 commits into from
Oct 5, 2023

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Oct 5, 2023 •
edited
Loading

Fixes #329

@aeschli aeschli self-assigned this Oct 5, 2023
@aeschli aeschli enabled auto-merge (squash) October 5, 2023 14:44
@aeschli aeschli merged commit 05e3631 into main Oct 5, 2023
7 checks passed
@aeschli aeschli deleted the aeschli/varied-fish branch October 5, 2023 14:48
@aeschli aeschli mentioned this pull request Oct 11, 2023
Closed
@starball5
Copy link

starball5 commented Oct 11, 2023 •
edited
Loading

What version of VS Code will the change be released in?

@aeschli aeschli added this to the October 2023 milestone Oct 12, 2023
@aeschli
Copy link
Contributor Author

aeschli commented Oct 12, 2023

It will be in 1.84

@wzrabbit wzrabbit mentioned this pull request Oct 19, 2023
Merged
This was referenced Dec 11, 2023
Merged
Closed
@marcoms
Copy link

marcoms commented Mar 3, 2024

@aeschli Do I need to do something to enable support? I am on 1.86.2

Screenshot 2024-03-03 at 4 35 47 PM

@aeschli
Copy link
Contributor Author

aeschli commented Mar 4, 2024

@marcoms Are you using the rule nested? Can you open a new issue with a complete code example?

@marcoms
Copy link

marcoms commented Mar 4, 2024

@marcoms Are you using the rule nested? Can you open a new issue with a complete code example?

Yes this is nested, non-nested works fine. I noticed issue #381 was opened recently for SCSS so I added a code sample there, but if it makes more sense to tackle them separately I can make a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiday-mar aiday-mar aiday-mar approved these changes

Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

The container property is not supported
4 participants
@aeschli @starball5 @marcoms @aiday-mar