Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for @container queries by updating the CSS language service #19

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

marvinroger
Copy link

Closes #14

This PR updates the CSS language service in order to support @container queries.

C.f. microsoft/vscode-css-languageservice#365 and microsoft/vscode-css-languageservice#371

The PR is ready to be published to npm 😉

I'll make a followup PR to https://github.com/styled-components/vscode-styled-components once published

@jasonwilliams
Copy link
Collaborator

jasonwilliams commented Dec 11, 2023

Seems good thanks for the contribution, the package lock has a different version to the package.json.
I will test later

@marvinroger
Copy link
Author

Thanks @jasonwilliams, just fixed the lockfile

@jasonwilliams
Copy link
Collaborator

oh dear, so many tests fail.
Not your fault, they fail even on master, I guess so many things have moved around since this was last built

@jasonwilliams
Copy link
Collaborator

Ok, no biggie, the e2e typescript version is just outdated compared to the main plugin typescript version.
Ill merge this and update them both, then figures crossed tests pass again

@jasonwilliams jasonwilliams merged commit 915ff5a into styled-components:main Dec 11, 2023
3 of 4 checks passed
@phuctm97
Copy link

phuctm97 commented Jun 5, 2024

For some reasons container query still doesn't work 🥹

@kitajchuk
Copy link

Also still not working for me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support container queries
4 participants